Bug 68391

Summary: check-webkit-style generates bogus warning for StructuredExceptionHandlerSupressor.h
Product: WebKit Reporter: Chris Marrin <cmarrin>
Component: Tools / TestsAssignee: David Levin <levin>
Severity: Normal CC: levin, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Description Flags
Patch darin: review+, webkit.review.bot: commit-queue-

Description Chris Marrin 2011-09-19 14:37:00 PDT
Style checking generates:

    Source/WebCore/platform/win/StructuredExceptionHandlerSupressor.h:52:  Extra space before [  [whitespace/braces] [5]

for this line:

    __asm mov [registration], eax

Seems like it doesn't understand Windows assembly well enough.
Comment 1 David Levin 2011-09-19 15:21:33 PDT
*** Bug 68400 has been marked as a duplicate of this bug. ***
Comment 2 David Levin 2011-09-19 15:23:28 PDT
Created attachment 107928 [details]
Comment 3 WebKit Review Bot 2011-09-19 17:06:47 PDT
Comment on attachment 107928 [details]

Rejecting attachment 107928 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 1

Last 500 characters of output:
r95496 = 6c67a85488c37041218b7b672434107e57743c3b
Done rebuilding .git/svn/refs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc
First, rewinding head to replay your work on top of it...
Fast-forwarded master to refs/remotes/origin/master.
Updating chromium port dependencies using gclient...

________ running '/usr/bin/python gyp_webkit' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium'
Updating webkit projects from gyp files...

Full output: http://queues.webkit.org/results/9772042
Comment 4 David Levin 2011-09-19 17:08:21 PDT
Whoops. I got too used to gardening and deleted the Reviewed by line. :(

Will commit by hand.
Comment 5 David Levin 2011-09-19 17:41:13 PDT
Committed as http://trac.webkit.org/changeset/95499