Bug 68391 – check-webkit-style generates bogus warning for StructuredExceptionHandlerSupressor.h

• Component: Tools / Tests
• Status: RESOLVED FIXED

[Chris Marrin]

Style checking generates:

    Source/WebCore/platform/win/StructuredExceptionHandlerSupressor.h:52:  Extra space before [  [whitespace/braces] [5]

for this line:

    __asm mov [registration], eax

Seems like it doesn't understand Windows assembly well enough.

[David Levin]

*** Bug 68400 has been marked as a duplicate of this bug. ***

[David Levin]

Created attachment 107928 [details]
Patch

[WebKit Review Bot]

Comment on attachment 107928 [details]
Patch

Rejecting attachment 107928 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 1

Last 500 characters of output:
9120b8ae0fc3dfd55045dd4b0a6061b6b9f6c511
r95496 = 6c67a85488c37041218b7b672434107e57743c3b
Done rebuilding .git/svn/refs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc
First, rewinding head to replay your work on top of it...
Fast-forwarded master to refs/remotes/origin/master.
Updating chromium port dependencies using gclient...

________ running '/usr/bin/python gyp_webkit' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium'
Updating webkit projects from gyp files...

Full output: http://queues.webkit.org/results/9772042

[David Levin]

Whoops. I got too used to gardening and deleted the Reviewed by line. :(

Will commit by hand.

[David Levin]

Committed as http://trac.webkit.org/changeset/95499