Bug 68379

Summary: Remove calls to -[WebView _usesDocumentViews] from WebFrameLoaderClient.mm
Product: WebKit Reporter: Anders Carlsson <andersca>
Component: New BugsAssignee: Anders Carlsson <andersca>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch aroben: review+

Description Anders Carlsson 2011-09-19 12:59:34 PDT
Remove calls to -[WebView _usesDocumentViews] from WebFrameLoaderClient.mm
Comment 1 Anders Carlsson 2011-09-19 12:59:53 PDT
Created attachment 107904 [details]
Patch
Comment 2 Adam Roben (:aroben) 2011-09-19 13:05:07 PDT
Comment on attachment 107904 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=107904&action=review

> Source/WebKit/mac/ChangeLog:6
> +        Remove calls to -[WebView _usesDocumentViews] from WebFrameLoaderClient.mm
> +        https://bugs.webkit.org/show_bug.cgi?id=68379
> +
> +        Reviewed by NOBODY (OOPS!).

Needs more explanation!

> Source/WebKit/mac/WebCoreSupport/WebFrameLoaderClient.mm:1232
> +    // FIXME (Viewless): I assume we want the equivalent of this optimization for viewless mode too.

Seems like we don't need this FIXME anymore.
Comment 3 Anders Carlsson 2011-09-19 13:06:43 PDT
Committed r95459: <http://trac.webkit.org/changeset/95459>