Summary: | Fix patch and bug numbering in the mocktool simulation code | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Tom Zakrajsek <tomz> | ||||
Component: | Tools / Tests | Assignee: | Tom Zakrajsek <tomz> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | abarth, eric, webkit.review.bot | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
Tom Zakrajsek
2011-09-19 11:30:10 PDT
There are some other things to fix in that code, but I didn't want to mix this checking with one doing anything else, for the reviewer's sake. One minor complication was that queues_unittest.py assumed that 2 was an invalid patch ID. I changed that test to use 1995. One question. Would you prefer to see the patch and bug ids as distinct from each other. If so, I could easily give each a base. For example, patches at 10000 and bugs at 50000 Yeah, that will help make sure we don't confuse them. Created attachment 107901 [details]
Patch
Comment on attachment 107901 [details] Patch Clearing flags on attachment: 107901 Committed r95543: <http://trac.webkit.org/changeset/95543> All reviewed patches have been landed. Closing bug. |