Bug 68374

Summary: Fix patch and bug numbering in the mocktool simulation code
Product: WebKit Reporter: Tom Zakrajsek <tomz>
Component: Tools / TestsAssignee: Tom Zakrajsek <tomz>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, eric, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Tom Zakrajsek
Reported 2011-09-19 11:30:10 PDT
This is to get rid of a few FIXME items by using a normal sequence for patch IDs and bug IDs in the mocktool simulation code. Current Patches --------------- 197 -> 1 128 -> 2 103 -> 3 104 -> 4 105 -> 5 106 -> 6 107 -> 7 Current Bugs --------------- 42 -> 1 75 -> 2 76 -> 3 77 -> 4 78 -> 5
Attachments
Patch (78.88 KB, patch)
2011-09-19 12:14 PDT, Tom Zakrajsek 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Tom Zakrajsek
Comment 1 2011-09-19 11:31:43 PDT
There are some other things to fix in that code, but I didn't want to mix this checking with one doing anything else, for the reviewer's sake. One minor complication was that queues_unittest.py assumed that 2 was an invalid patch ID. I changed that test to use 1995. One question. Would you prefer to see the patch and bug ids as distinct from each other. If so, I could easily give each a base. For example, patches at 10000 and bugs at 50000
Adam Barth
Comment 2 2011-09-19 11:44:02 PDT
Yeah, that will help make sure we don't confuse them.
Tom Zakrajsek
Comment 3 2011-09-19 12:14:09 PDT
Created attachment 107901 [details] Patch
WebKit Review Bot
Comment 4 2011-09-20 08:42:13 PDT
Comment on attachment 107901 [details] Patch Clearing flags on attachment: 107901 Committed r95543: <http://trac.webkit.org/changeset/95543>
WebKit Review Bot
Comment 5 2011-09-20 08:42:17 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.