Bug 68373

Summary:

Remove direct property slot pointers from the instruction stream

Product:

WebKit

Reporter:

Oliver Hunt <oliver>

Component:

New Bugs

Assignee:

Oliver Hunt <oliver>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

aroben

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	barraclough: review+

Description Oliver Hunt 2011-09-19 11:05:44 PDT

Remove direct property slot pointers from the instruction stream

Comment 1 Oliver Hunt 2011-09-19 11:07:35 PDT

Created attachment 107889 [details]
Patch

Comment 2 Oliver Hunt 2011-09-19 11:29:30 PDT

Committed r95447: <http://trac.webkit.org/changeset/95447>

Comment 3 Adam Roben (:aroben) 2011-09-19 12:28:14 PDT

This broke Windows (at least): http://build.webkit.org/builders/Windows%20Release%20%28Build%29/builds/21076/steps/compile-webkit/logs/stdio

Comment 4 Adam Roben (:aroben) 2011-09-19 12:29:32 PDT

Actually I think it broke 32-bit Mac, too:

JavaScriptCore/jit/JITPropertyAccess32_64.cpp: In member function 'void JSC::JIT::compileGetDirectOffset(JSC::JSObject*, JSC::X86Registers::RegisterID, JSC::X86Registers::RegisterID, size_t)':
JavaScriptCore/jit/JITPropertyAccess32_64.cpp:462: error: 'result' was not declared in this scope
cc1plus: warnings being treated as errors
JavaScriptCore/jit/JITPropertyAccess32_64.cpp: At global scope:
JavaScriptCore/jit/JITPropertyAccess32_64.cpp:459: warning: unused parameter 'resultPayload'