Bug 68358

Summary: Add fontDataForCombiningCharacterSequence to fix Skia on Mac build
Product: WebKit Reporter: Cary Clark <caryclark>
Component: New BugsAssignee: Cary Clark <caryclark>
Status: RESOLVED FIXED    
Severity: Normal CC: mitz, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Cary Clark
Reported 2011-09-19 07:22:36 PDT
Add fontDataForCombiningCharacterSequence to fix Skia on Mac build
Attachments
Patch (2.71 KB, patch)
2011-09-19 07:26 PDT, Cary Clark 		no flags
DetailsFormatted DiffDiff
Patch (4.59 KB, patch)
2011-09-19 09:33 PDT, Cary Clark 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Cary Clark
Comment 1 2011-09-19 07:26:02 PDT
Created attachment 107850 [details] Patch
mitz
Comment 2 2011-09-19 08:18:54 PDT
Comment on attachment 107850 [details] Patch Duplicating this code seems bad. A better solution would be to share it. r- because if you do copy this code, then you must also add the 2011 Apple Inc. copyright to the file.
Cary Clark
Comment 3 2011-09-19 08:31:04 PDT
I'm happy to share the code, but I am unsure where the shared code should reside. Where would you recommend? Alternatively, would you still object to committing the code if the copyright statement was added to FontSkia.cpp?
Cary Clark
Comment 4 2011-09-19 08:53:05 PDT
How about moving the function from FontMac.mm to FontComplexTextMac.cpp. Does that work for you?
mitz
Comment 5 2011-09-19 09:04:58 PDT
(In reply to comment #4) > How about moving the function from FontMac.mm to FontComplexTextMac.cpp. That’s a good option
Cary Clark
Comment 6 2011-09-19 09:33:58 PDT
Created attachment 107874 [details] Patch
WebKit Review Bot
Comment 7 2011-09-19 11:26:42 PDT
Comment on attachment 107874 [details] Patch Clearing flags on attachment: 107874 Committed r95445: <http://trac.webkit.org/changeset/95445>
WebKit Review Bot
Comment 8 2011-09-19 11:26:46 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.