| Summary: | [GTK] Fix distcheck build | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Carlos Garcia Campos <cgarcia> | ||||
| Component: | WebKitGTK | Assignee: | Nobody <webkit-unassigned> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | mrobinson, pnormand, webkit.review.bot | ||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | PC | ||||||
| OS: | Linux | ||||||
| Attachments: |
|
||||||
|
Description
Carlos Garcia Campos
2011-09-19 03:21:23 PDT
Created attachment 107826 [details]
Patch
Comment on attachment 107826 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=107826&action=review Looks good overall, just a doubt of the mime-type handling test. > Source/WebKit/gtk/tests/testmimehandling.c:-79 > - } else if (g_str_equal(path, "/ogg")) { Hum, why remove this part of the test? If it fails we'd better fix it. (In reply to comment #2) > (From update of attachment 107826 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=107826&action=review > > Looks good overall, just a doubt of the mime-type handling test. > > > Source/WebKit/gtk/tests/testmimehandling.c:-79 > > - } else if (g_str_equal(path, "/ogg")) { > > Hum, why remove this part of the test? If it fails we'd better fix it. Soup behaviour has changed, the "fix" would depend on soup version, so we should bump the soup requirements to make sure the test won't fail. See: https://bugzilla.gnome.org/show_bug.cgi?id=648846#c8 So, for now we have decided to remove that part of the test. Oh, OK then :) I've missed that link you also mentionned in the ChangeLog, sorry. Comment on attachment 107826 [details] Patch Clearing flags on attachment: 107826 Committed r95417: <http://trac.webkit.org/changeset/95417> All reviewed patches have been landed. Closing bug. In the future, I think it would be better to update the source lists and fix the tests in two separate patches. That would allow an automatic rollout when the soup version is updated. Source list updates do not need review either, so it isn't much harder. (In reply to comment #7) > In the future, I think it would be better to update the source lists and fix the tests in two separate patches. That would allow an automatic rollout when the soup version is updated. Source list updates do not need review either, so it isn't much harder. Ok, sorry, in this case just updating libsoup wound't work, we need to rethink the test itself, but still, you are right. |