| Summary: | [chromium] Disable clang when building chromium in WebKit | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | jochen | ||||||
| Component: | New Bugs | Assignee: | jochen | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | abarth, thakis, webkit.review.bot | ||||||
| Priority: | P2 | ||||||||
| Version: | 528+ (Nightly build) | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
|
Description
jochen
2011-09-19 02:11:37 PDT
Created attachment 107818 [details]
Patch
an alternative would be to add a dependencies on tools/clang Comment on attachment 107818 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=107818&action=review LGTM, sorry for the breakage. You can submit this as "Unreviewed, build fix" (then you don't need to wait for a formal r+). > Source/WebKit/chromium/gyp_webkit:107 > + '-Dclang_use_chrome_plugins=0', This line should be enough, you shouldn't need the one above it (but it doesn't hurt either). Maybe add "# http://crbug.com/97043". Adding a dependency on tools/clang seems better. We want the upstream and downstream builds to use the same compiler. (In reply to comment #4) > Adding a dependency on tools/clang seems better. We want the upstream and downstream builds to use the same compiler. Yes, I'll get to that. But since the build uses gcc at the moment anyway, unbreaking this until I do seems better than leaving it broken. Created attachment 107885 [details]
Patch
Comment on attachment 107885 [details]
Patch
Okiedokes!
Comment on attachment 107885 [details] Patch Clearing flags on attachment: 107885 Committed r95454: <http://trac.webkit.org/changeset/95454> All reviewed patches have been landed. Closing bug. |