Bug 68336

Summary: Implement an ErrorEvent constructor for V8
Product: WebKit Reporter: Kentaro Hara <haraken>
Component: DOMAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, ap, dominicc, haraken, sam, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 67824    
Attachments:
Description Flags
Patch
abarth: review+
rebased patch for commit none

Description Kentaro Hara 2011-09-18 23:59:45 PDT 
We have been working on implementing constructors of Events. ErrorEvent has a constructor in JSC (https://bugs.webkit.org/show_bug.cgi?id=67924), but do not have it in V8.
Comment 1 Kentaro Hara 2011-09-19 00:38:22 PDT 
Created attachment 107812 [details]
Patch
Comment 2 Kentaro Hara 2011-09-19 00:38:41 PDT 
I confirmed that fast/events/constructors/error-event-constructor.html passes clang build.

The numerical conversion problem (https://bugs.webkit.org/show_bug.cgi?id=67980) seems to happen on an unsigned long long value but not to happen on an unsigned long value.
Comment 3 Kentaro Hara 2011-09-28 01:20:32 PDT 
Created attachment 108984 [details]
rebased patch for commit
Comment 4 WebKit Review Bot 2011-09-28 02:27:04 PDT 
Comment on attachment 108984 [details]
rebased patch for commit

Clearing flags on attachment: 108984

Committed r96208: <http://trac.webkit.org/changeset/96208>