Bug 68313

Summary: Web Inspector: chromium: "Save timeline data" does nothing .
Product: WebKit Reporter: Ilya Tikhonovsky <loislo>
Component: Web Inspector (Deprecated)Assignee: Ilya Tikhonovsky <loislo>
Status: RESOLVED FIXED    
Severity: Normal CC: apavlov, bweinstein, fam.lam, joepeck, keishi, loislo, pfeldman, pmuellr, rik, timothy, yurys
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: Windows 7   
Attachments:
Description Flags
[patch] initial version
none
[patch] second iteration pfeldman: review+, pfeldman: commit-queue-

Description Ilya Tikhonovsky 2011-09-17 12:15:01 PDT 
windows shell API function GetSaveFileName doesn't accept file names with ':' symbol.
Comment 1 Ilya Tikhonovsky 2011-09-17 12:30:51 PDT 
Created attachment 107771 [details]
[patch] initial version
Comment 2 Ilya Tikhonovsky 2011-09-18 01:46:33 PDT 
Created attachment 107788 [details]
[patch] second iteration
Comment 3 Pavel Feldman 2011-09-18 05:29:25 PDT 
Comment on attachment 107788 [details]
[patch] second iteration

View in context: https://bugs.webkit.org/attachment.cgi?id=107788&action=review

> Source/WebCore/inspector/front-end/utilities.js:552
> +           (!offset ? "Z" : offsetString);

No need to include 'Z' and offset. No Z should be treated as local (non UTC time).
Comment 4 Ilya Tikhonovsky 2011-09-18 22:33:47 PDT 
Committed r95401: <http://trac.webkit.org/changeset/95401>