Bug 68313

Summary:

Web Inspector: chromium: "Save timeline data" does nothing .

Product:

WebKit

Reporter:

Ilya Tikhonovsky <loislo>

Component:

Web Inspector (Deprecated)

Assignee:

Ilya Tikhonovsky <loislo>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

apavlov, bweinstein, fam.lam, joepeck, keishi, loislo, pfeldman, pmuellr, rik, timothy, yurys

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

Windows 7

Attachments:

Description	Flags
[patch] initial version	none
[patch] second iteration	pfeldman: review+, pfeldman: commit-queue-

Ilya Tikhonovsky

Reported 2011-09-17 12:15:01 PDT

windows shell API function GetSaveFileName doesn't accept file names with ':' symbol.

Attachments
[patch] initial version (1.41 KB, patch) 2011-09-17 12:30 PDT, Ilya Tikhonovsky	no flags	Details Formatted Diff Diff
[patch] second iteration (2.78 KB, patch) 2011-09-18 01:46 PDT, Ilya Tikhonovsky	pfeldman: review+ pfeldman: commit-queue-	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Ilya Tikhonovsky

Comment 1 2011-09-17 12:30:51 PDT

Created attachment 107771 [details] [patch] initial version

Ilya Tikhonovsky

Comment 2 2011-09-18 01:46:33 PDT

Created attachment 107788 [details] [patch] second iteration

Pavel Feldman

Comment 3 2011-09-18 05:29:25 PDT

Comment on attachment 107788 [details] [patch] second iteration View in context: https://bugs.webkit.org/attachment.cgi?id=107788&action=review > Source/WebCore/inspector/front-end/utilities.js:552 > + (!offset ? "Z" : offsetString); No need to include 'Z' and offset. No Z should be treated as local (non UTC time).

Ilya Tikhonovsky

Comment 4 2011-09-18 22:33:47 PDT

Note You need to log in before you can comment on or make changes to this bug.