Bug 68293

Summary: FrameLoaderClient BackForwardList-related methods are unused
Product: WebKit Reporter: Mihai Parparita <mihaip>
Component: HistoryAssignee: Mihai Parparita <mihaip>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, beidson, benm, fishd, peter, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Mihai Parparita
Reported 2011-09-16 17:11:16 PDT
As far as I can tell, dispatchDidAddBackForwardItem, dispatchDidRemoveBackForwardItem and dispatchDidChangeBackForwardIndex all have no-op implementations in the various FrameLoaderClient implementations. It looks like they were added by http://trac.webkit.org/changeset/51629 for the old Android port. I assume they're no longer needed for the new (Chromium-based) one?
Attachments
Patch (32.55 KB, patch)
2011-09-16 17:35 PDT, Mihai Parparita 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Adam Barth
Comment 1 2011-09-16 17:12:37 PDT
It's unlikely they'll be needed by the new Android port because it shares its back/forward logic with the other Chromium ports.
Mihai Parparita
Comment 2 2011-09-16 17:13:00 PDT
I'll remove them.
Mihai Parparita
Comment 3 2011-09-16 17:35:53 PDT
Created attachment 107753 [details] Patch
Mihai Parparita
Comment 4 2011-09-16 17:39:30 PDT
Will wait for the EWS to go through this patch before trying to land it.
WebKit Review Bot
Comment 5 2011-09-17 16:31:00 PDT
Comment on attachment 107753 [details] Patch Clearing flags on attachment: 107753 Committed r95387: <http://trac.webkit.org/changeset/95387>
WebKit Review Bot
Comment 6 2011-09-17 16:31:05 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.