Bug 68293

Summary: FrameLoaderClient BackForwardList-related methods are unused
Product: WebKit Reporter: Mihai Parparita <mihaip>
Component: HistoryAssignee: Mihai Parparita <mihaip>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, beidson, benm, fishd, peter, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Description Mihai Parparita 2011-09-16 17:11:16 PDT 
As far as I can tell, dispatchDidAddBackForwardItem, dispatchDidRemoveBackForwardItem and dispatchDidChangeBackForwardIndex all have no-op implementations in the various FrameLoaderClient implementations. It looks like they were added by http://trac.webkit.org/changeset/51629 for the old Android port. I assume they're no longer needed for the new (Chromium-based) one?
Comment 1 Adam Barth 2011-09-16 17:12:37 PDT 
It's unlikely they'll be needed by the new Android port because it shares its back/forward logic with the other Chromium ports.
Comment 2 Mihai Parparita 2011-09-16 17:13:00 PDT 
I'll remove them.
Comment 3 Mihai Parparita 2011-09-16 17:35:53 PDT 
Created attachment 107753 [details]
Patch
Comment 4 Mihai Parparita 2011-09-16 17:39:30 PDT 
Will wait for the EWS to go through this patch before trying to land it.
Comment 5 WebKit Review Bot 2011-09-17 16:31:00 PDT 
Comment on attachment 107753 [details]
Patch

Clearing flags on attachment: 107753

Committed r95387: <http://trac.webkit.org/changeset/95387>
Comment 6 WebKit Review Bot 2011-09-17 16:31:05 PDT 
All reviewed patches have been landed.  Closing bug.