Summary: | ASSERTION FAILED: documentLoader in WebKit/Source/WebCore/inspector/InspectorInstrumentation.cpp(597) | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Tony Chang <tony> | ||||||||
Component: | Web Inspector (Deprecated) | Assignee: | Vsevolod Vlasov <vsevik> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | ap, loislo, pfeldman, vsevik, yurys | ||||||||
Priority: | P2 | ||||||||||
Version: | 528+ (Nightly build) | ||||||||||
Hardware: | Unspecified | ||||||||||
OS: | Unspecified | ||||||||||
Attachments: |
|
Description
Tony Chang
2011-09-16 16:36:36 PDT
Created attachment 107745 [details]
test server
Probably related: http://code.google.com/p/chromium/issues/detail?id=94392 Created attachment 108323 [details]
Patch
I was not able to reproduce this bug, but this piece of code could be simplified to ensure this does not happens anymore. Comment on attachment 108323 [details] Patch Attachment 108323 [details] did not pass mac-ews (mac): Output: http://queues.webkit.org/results/9794302 Created attachment 108368 [details]
Patch
Comment on attachment 108368 [details]
Patch
Seems fine. Might want to have someone more familiar with Inspector code also take a look.
(In reply to comment #7) > (From update of attachment 108368 [details]) > Seems fine. Might want to have someone more familiar with Inspector code also take a look. Tony, are you sure url != documentLoader->requestURL() check was redundant there? Comment on attachment 108368 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=108368&action=review > Source/WebCore/inspector/InspectorInstrumentation.cpp:-602 > - if (frame->page()->mainFrame() != frame || url != documentLoader->requestURL()) Do we receive load event notifications only for the frame main resource? If not, the check should be preserved. (In reply to comment #9) > (From update of attachment 108368 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=108368&action=review > > > Source/WebCore/inspector/InspectorInstrumentation.cpp:-602 > > - if (frame->page()->mainFrame() != frame || url != documentLoader->requestURL()) > > Do we receive load event notifications only for the frame main resource? If not, the check should be preserved. loadEventFired() and domContentLoadedEventFired() are called only from DOMWindow and Document always passing frame main resource url. Committed r95790: <http://trac.webkit.org/changeset/95790> |