Bug 68276 – 3D transforms are flattened in WebKit2 snapshots

• Component: WebKit2
• Status: RESOLVED FIXED

[Simon Fraser (smfr)]

Images of WK2 views flatten 3d transforms (they do a flattening paint, rather than capturing the window). This breaks pixel tests that contain 3d rendering (e.g. compositing/flat-with-transformed-child.html), and means that Safari snapshots don't show 3d.

[Simon Fraser (smfr)]

Created attachment 110018 [details]
Patch

[Darin Adler]

Comment on attachment 110018 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=110018&action=review

> Tools/WebKitTestRunner/cg/TestInvocationCG.mm:47
> +namespace WTR {

I think that if we used "svn move" I could see the changes to this file. Because we just added a new file, I can’t see the diffs.

[Simon Fraser (smfr)]

git will end up detecting the rename and will show this as an svn mv on commit.

[Simon Fraser (smfr)]

Created attachment 110064 [details]
TestInvocationCG diff

[Simon Fraser (smfr)]

http://trac.webkit.org/changeset/97082

[Simon Fraser (smfr)]

Reopening: broke windows.

[Simon Fraser (smfr)]

Created attachment 110431 [details]
Patch which fixes Windows build

[Simon Fraser (smfr)]

http://trac.webkit.org/changeset/97104

[Adam Roben (:aroben)]

Comment on attachment 110431 [details]
Patch which fixes Windows build

View in context: https://bugs.webkit.org/attachment.cgi?id=110431&action=review

> Tools/WebKitTestRunner/mac/PlatformWebViewMac.mm:135
> +    return WKImageCreateFromCGImage(windowSnapshotImage.get(), 0);

This causes a leak. You need to adopt the image.

[Simon Fraser (smfr)]

Created attachment 110719 [details]
Patch

[Simon Fraser (smfr)]

Comment on attachment 110719 [details]
Patch

http://trac.webkit.org/changeset/97285