Bug 68268

Summary: Give local builds of WebProcess different icon to distinguish them from built-in Safari’s WebProcess
Product: WebKit Reporter: Alexey Proskuryakov <ap>
Component: WebKit2Assignee: Alexey Proskuryakov <ap>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
proposed patch
none
updated patch darin: review+

Alexey Proskuryakov
Reported 2011-09-16 12:22:55 PDT
It's difficult to pick a proper WebProcess to attach in Xcode - you don't want to attach to a production one when released Safari/WebKit is running. Having a different icon in Xcode menu would help.
Attachments
proposed patch (134.45 KB, patch)
2011-09-16 12:32 PDT, Alexey Proskuryakov 		no flags
DetailsFormatted DiffDiff
updated patch (130.54 KB, patch)
2011-09-16 12:41 PDT, Alexey Proskuryakov 		darin: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Alexey Proskuryakov
Comment 1 2011-09-16 12:32:31 PDT
Created attachment 107704 [details] proposed patch
Alexey Proskuryakov
Comment 2 2011-09-16 12:41:24 PDT
Created attachment 107706 [details] updated patch Re-did xcodeproj changes to remove traces of experimentation.
Darin Adler
Comment 3 2011-09-16 12:44:54 PDT
Comment on attachment 107706 [details] updated patch Nothing here says why we want to do this. That’s why I can’t review.
Darin Adler
Comment 4 2011-09-16 12:57:18 PDT
Comment on attachment 107706 [details] updated patch I see now; I missed the rationale that was in the bug. I think the real title of this bug should be: Give local builds of WebProcess different icon to distinguish then from built-in Safari’s WebProcess
Alexey Proskuryakov
Comment 5 2011-09-16 13:05:43 PDT
Good point, renamed. Committed <http://trac.webkit.org/changeset/95314>.
Note You need to log in before you can comment on or make changes to this bug.