|Summary:||add non-CG Webkit-Mac builds to flakiness dashboard|
|Component:||Tools / Tests||Assignee:||epoger|
|Version:||528+ (Nightly build)|
Description epoger 2011-09-16 11:56:43 PDT
add non-CG Webkit-Mac builds to http://test-results.appspot.com/dashboards/flakiness_dashboard.html patterned after part of http://trac.webkit.org/changeset/93242
Comment 2 Adam Barth 2011-09-16 12:04:33 PDT
Comment on attachment 107696 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=107696&action=review > Tools/ChangeLog:6 > + Reviewed by Adam Barth. Generally you should leave this line with the default text. The tools will fill it in properly based on whoever actually reviews the patch. > Tools/ChangeLog:7 > + It's also a good idea to fill out some of the ChangeLog entry with an explanation of why you're making this change. In this case, I'd say something about how we're preparing to make these the default builders. > Tools/TestResultServer/static-dashboards/flakiness_dashboard_tests.js:36 > -// FIXME: move this over to using qunit > +// FIXME(ojan): move this over to using qunit WebKit doesn't use the (ojan) notation. Just FIXME.
Comment 4 epoger 2011-09-16 12:17:55 PDT
fixed the issues Adam pointed out.
Comment 6 WebKit Review Bot 2011-09-16 22:52:56 PDT
Comment on attachment 107698 [details] Patch Clearing flags on attachment: 107698 Committed r95370: <http://trac.webkit.org/changeset/95370>
Comment 7 WebKit Review Bot 2011-09-16 22:53:01 PDT
All reviewed patches have been landed. Closing bug.