| Summary: | CodeGeneratorGObject should use C++ style comments for ENABLE guards | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Adam Barth <abarth> | ||||
| Component: | New Bugs | Assignee: | Adam Barth <abarth> | ||||
| Status: | RESOLVED WONTFIX | ||||||
| Severity: | Normal | CC: | darin, ossy, rniwa, zimmermann | ||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Bug Depends on: | 68299 | ||||||
| Bug Blocks: | |||||||
| Attachments: |
|
||||||
|
Description
Adam Barth
2011-09-16 10:33:05 PDT
Created attachment 107680 [details]
Patch
Comment on attachment 107680 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=107680&action=review > Source/WebCore/bindings/scripts/CodeGeneratorGObject.pm:58 > + * This file is part of the WebKit open source project. > + * This file has been generated by generate-bindings.pl. DO NOT MODIFY! Not specific to this patch, really, but I don’t think that adding stars to every line improves this comment. In fact, I think this format should be considered an anti-pattern in the future. Those additional stars make it slightly easier to spot that it's a comment, but also make comments harder to edit with any non-advanced editing tools. If we really want something on every line, then we should just use // comments. The whole benefit of /* */ comments is that they are multiline without requiring additional characters on every line. Ok. I'll change them to //, which is also a common style for license blocks in the project. I'm not sure it's such a big deal for these generated files. Mostly it was the ENABLE-guard comments that I bumped into. Committed r95304: <http://trac.webkit.org/changeset/95304> I had to roll this patch out because GTK+ pulls the derived headers in main.c. Whatever. This is too much work for too little benefit. (In reply to comment #6) > Whatever. This is too much work for too little benefit. Yeah, I completely agree. |