Bug 68252

Summary: update-webkit-chromium should retry the gclient call if it fails once
Product: WebKit Reporter: Tom Zakrajsek <tomz>
Component: Tools / TestsAssignee: Tom Zakrajsek <tomz>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, eric, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Tom Zakrajsek
Reported 2011-09-16 10:02:43 PDT
update-webkit-chromium sometimes fails when run from the bots because gclient can be flaky, as demonstrated in https://bugs.webkit.org/show_bug.cgi?id=67857#c6. We should allow the script to retry the gclient call in case a given failure is transient.
Attachments
Patch (1.59 KB, patch)
2011-09-16 10:09 PDT, Tom Zakrajsek 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Tom Zakrajsek
Comment 1 2011-09-16 10:09:04 PDT
Created attachment 107674 [details] Patch
Adam Barth
Comment 2 2011-09-16 10:12:15 PDT
Comment on attachment 107674 [details] Patch Do we want to back-off at all? There are also cases where gclient fails because you've screwed up editing the GYP file, and those shouldn't be retried... This is probably a good start though.
Tom Zakrajsek
Comment 3 2011-09-16 10:21:33 PDT
I'm not sure how to determine which failures should or shouldn't be retried. Maybe based on the specific errorcode? I'll think about ways to identify which ones would make sense to retry or not. I think the worst current case would be that if you break a gyp file, it will retry (with no chance of success) and cost a little extra time.
WebKit Review Bot
Comment 4 2011-09-16 21:14:18 PDT
Comment on attachment 107674 [details] Patch Clearing flags on attachment: 107674 Committed r95363: <http://trac.webkit.org/changeset/95363>
WebKit Review Bot
Comment 5 2011-09-16 21:14:23 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.