Summary: | update-webkit-chromium should retry the gclient call if it fails once | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Tom Zakrajsek <tomz> | ||||
Component: | Tools / Tests | Assignee: | Tom Zakrajsek <tomz> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | abarth, eric, webkit.review.bot | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
Tom Zakrajsek
2011-09-16 10:02:43 PDT
Created attachment 107674 [details]
Patch
Comment on attachment 107674 [details]
Patch
Do we want to back-off at all? There are also cases where gclient fails because you've screwed up editing the GYP file, and those shouldn't be retried... This is probably a good start though.
I'm not sure how to determine which failures should or shouldn't be retried. Maybe based on the specific errorcode? I'll think about ways to identify which ones would make sense to retry or not. I think the worst current case would be that if you break a gyp file, it will retry (with no chance of success) and cost a little extra time. Comment on attachment 107674 [details] Patch Clearing flags on attachment: 107674 Committed r95363: <http://trac.webkit.org/changeset/95363> All reviewed patches have been landed. Closing bug. |