Summary: | Web Inspector: limit the use of "Resource" term in the protocol. | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Pavel Feldman <pfeldman> | ||||||
Component: | Web Inspector (Deprecated) | Assignee: | Pavel Feldman <pfeldman> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | apavlov, bweinstein, joepeck, keishi, loislo, pfeldman, pmuellr, rik, timothy, vsevik, yurys | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | All | ||||||||
OS: | All | ||||||||
Attachments: |
|
Description
Pavel Feldman
2011-09-16 09:35:34 PDT
Created attachment 107667 [details]
Patch
Comment on attachment 107667 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=107667&action=review > Source/WebCore/inspector/Inspector.json:76 > + { "name": "loaderId", "$ref": "Network.LoaderId", "description": "Identifier of the loader associated with this frame." }, How is that related to the bug description? > Source/WebCore/inspector/Inspector.json:351 > + { "name": "stackTrace", "$ref": "StackTrace", "optional": true, "description": "JavaScript stack trace for assertions and error messages." } And that? > Source/WebCore/inspector/Inspector.json:428 > + "description": "Network domain allows tracking network activities of the page. It exposes information about HTTP requests and responses, their headers, bodies, timing, etc.", It also exposes information about FTP, WebSocket, file:// and other types of activities. I think this descriptin is confusing. Comment on attachment 107667 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=107667&action=review >> Source/WebCore/inspector/Inspector.json:76 >> + { "name": "loaderId", "$ref": "Network.LoaderId", "description": "Identifier of the loader associated with this frame." }, > > How is that related to the bug description? Drive-by making loaderId strong-typed. >> Source/WebCore/inspector/Inspector.json:351 >> + { "name": "stackTrace", "$ref": "StackTrace", "optional": true, "description": "JavaScript stack trace for assertions and error messages." } > > And that? Drive-by fix. >> Source/WebCore/inspector/Inspector.json:428 >> + "description": "Network domain allows tracking network activities of the page. It exposes information about HTTP requests and responses, their headers, bodies, timing, etc.", > > It also exposes information about FTP, WebSocket, file:// and other types of activities. I think this descriptin is confusing. Fixed. Created attachment 107997 [details]
Patch
Looks good. Committed r95613: <http://trac.webkit.org/changeset/95613> |