Depend on harfbuzz for OS=Android as well

• Component: WebCore Misc.
• Status: RESOLVED FIXED

[Peter Beverloo]

Android depends on harfbuzz as well, so reflect that in the project file.  Furthermore, fix a compile error in PopupListBox.cpp by explicitly including ctype.h, as isspace otherwise won't be enabled.

[Peter Beverloo]

Created attachment 107634 [details]
Patch

[Steve Block]

Comment on attachment 107634 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=107634&action=review

> Source/WebCore/ChangeLog:6
> +        Android depends on harfbuzz as well, so reflect that in the project

'as well as GTK'

> Source/WebCore/ChangeLog:8
> +        explicitly including ctype.h, as isspace otherwise won't be enabled.

s/enabled/declared ?

[Peter Beverloo]

Created attachment 107637 [details]
Patch

(In reply to comment #2)
> (From update of attachment 107634 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=107634&action=review
> 
> > Source/WebCore/ChangeLog:6
> > +        Android depends on harfbuzz as well, so reflect that in the project
> 
> 'as well as GTK'

That would say that Android depends on GTK too, which is not the case.  I've rephrased the sentence.

> 
> > Source/WebCore/ChangeLog:8
> > +        explicitly including ctype.h, as isspace otherwise won't be enabled.
> 
> s/enabled/declared ?

Done.

Thanks!

[Steve Block]

Comment on attachment 107637 [details]
Patch

r=me

[WebKit Review Bot]

Comment on attachment 107637 [details]
Patch

Clearing flags on attachment: 107637

Committed r95356: <http://trac.webkit.org/changeset/95356>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.