Bug 68223

Summary: [Qt] Crash when dragging google maps.
Product: WebKit Reporter: Leo Yang <leo.yang>
Component: WebKit QtAssignee: Leo Yang <leo.yang>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
URL: http://maps.google.com
Attachments:
Description Flags
Patch abarth: review+

Description Leo Yang 2011-09-15 22:42:23 PDT 
Use QtTestBrowser

1. Load http://maps.google.com.
2. Drag the map.

It's very likely to crash.
Comment 1 Leo Yang 2011-09-15 22:57:23 PDT 
Created attachment 107605 [details]
Patch
Comment 2 Adam Barth 2011-09-15 23:43:25 PDT 
Comment on attachment 107605 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=107605&action=review

> Source/WebCore/platform/qt/CursorQt.cpp:203
> +            m_platformCursor = new QCursor(Qt::ArrowCursor);

m_platformCursor isn't any sort of smart pointer?
Comment 3 Leo Yang 2011-09-16 00:15:18 PDT 
Committed r95275: <http://trac.webkit.org/changeset/95275>
Comment 4 Alexis Menard (darktears) 2011-09-16 04:35:06 PDT 
Comment on attachment 107605 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=107605&action=review

>> Source/WebCore/platform/qt/CursorQt.cpp:203
>> +            m_platformCursor = new QCursor(Qt::ArrowCursor);
> 
> m_platformCursor isn't any sort of smart pointer?

It's deleted in the destructor but yes could be an improvement. Though it is define as mutable PlatformCursor m_platformCursor; for every port except Mac where it is : mutable RetainPtr<NSCursor> m_platformCursor; Definitively some improvements possible here.