Bug 68215

Summary: DFG JIT does not optimize method_check
Product: WebKit Reporter: Filip Pizlo <fpizlo>
Component: JavaScriptCoreAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
the patch
none
the patch - fix style oliver: review+

Filip Pizlo
Reported 2011-09-15 20:08:58 PDT
The DFG JIT emits a lot of code for method_check even though it has a plethora of profiling information that it could use (both from the meta-data in MethodCallLinkInfo and ValueProfile's) to determine how to optimize method_check down to a small number of instructions.
Attachments
the patch (37.81 KB, patch)
2011-09-15 20:14 PDT, Filip Pizlo 		no flags
DetailsFormatted DiffDiff
the patch - fix style (40.50 KB, patch)
2011-09-15 20:21 PDT, Filip Pizlo 		oliver: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Filip Pizlo
Comment 1 2011-09-15 20:14:46 PDT
Created attachment 107590 [details] the patch
WebKit Review Bot
Comment 2 2011-09-15 20:17:44 PDT
Attachment 107590 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source..." exit_code: 1 Source/JavaScriptCore/dfg/DFGSpeculativeJIT.cpp:53: An else statement can be removed when the prior "if" concludes with a return, break, continue or goto statement. [readability/control_flow] [4] Source/JavaScriptCore/dfg/DFGSpeculativeJIT.cpp:239: An else statement can be removed when the prior "if" concludes with a return, break, continue or goto statement. [readability/control_flow] [4] Total errors found: 2 in 20 files If any of these errors are false positives, please file a bug against check-webkit-style.
Filip Pizlo
Comment 3 2011-09-15 20:21:17 PDT
Created attachment 107592 [details] the patch - fix style
Filip Pizlo
Comment 4 2011-09-15 23:34:22 PDT
Landed in r95273.
Note You need to log in before you can comment on or make changes to this bug.