Summary: | Rename ENABLE(DATABASE) to ENABLE(SQL_DATABASE) | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Adam Barth <abarth> | ||||||||
Component: | New Bugs | Assignee: | Adam Barth <abarth> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | eric | ||||||||
Priority: | P2 | ||||||||||
Version: | 528+ (Nightly build) | ||||||||||
Hardware: | Unspecified | ||||||||||
OS: | Unspecified | ||||||||||
Bug Depends on: | |||||||||||
Bug Blocks: | 68012 | ||||||||||
Attachments: |
|
Description
Adam Barth
2011-09-15 18:34:25 PDT
Created attachment 107581 [details]
Patch
Comment on attachment 107581 [details] Patch Attachment 107581 [details] did not pass qt-ews (qt): Output: http://queues.webkit.org/results/9706157 Comment on attachment 107581 [details] Patch Attachment 107581 [details] did not pass efl-ews (efl): Output: http://queues.webkit.org/results/9694259 Created attachment 107597 [details]
Patch
Comment on attachment 107597 [details] Patch Attachment 107597 [details] did not pass qt-ews (qt): Output: http://queues.webkit.org/results/9709054 Created attachment 107602 [details]
Patch
Comment on attachment 107602 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=107602&action=review build-webkit changes? You might want to grep for"database_" as well. > configure.ac:1135 > +AM_CONDITIONAL([ENABLE_SQL_DATABASE],[test "$enable_sql_database" = "yes"]) I'm surprised this isn't referenced in more places in this file. > Source/JavaScriptCore/wtf/Platform.h:816 > -#if !defined(ENABLE_DATABASE) > -#define ENABLE_DATABASE 1 > +#if !defined(ENABLE_SQL_DATABASE) > +#define ENABLE_SQL_DATABASE 1 > #endif I thought we'd moved away from this model? (In reply to comment #7) > (From update of attachment 107602 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=107602&action=review > > build-webkit changes? You might want to grep for"database_" as well. Oops. Fixed. > > configure.ac:1135 > > +AM_CONDITIONAL([ENABLE_SQL_DATABASE],[test "$enable_sql_database" = "yes"]) > > I'm surprised this isn't referenced in more places in this file. I'll double-check. > > Source/JavaScriptCore/wtf/Platform.h:816 > > -#if !defined(ENABLE_DATABASE) > > -#define ENABLE_DATABASE 1 > > +#if !defined(ENABLE_SQL_DATABASE) > > +#define ENABLE_SQL_DATABASE 1 > > #endif > > I thought we'd moved away from this model? I think that's the plan, but I'm not sure it's happened yet. Committed r95271: <http://trac.webkit.org/changeset/95271> Comment on attachment 107602 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=107602&action=review > Source/WebCore/bindings/scripts/test/GObject/WebKitDOMTestCallback.cpp:235 > -#endif /* ENABLE(DATABASE) */ > +#endif // ENABLE(SQL_DATABASE) This change was incorrect, it broke binding test. Fix landed in http://trac.webkit.org/changeset/95294 (In reply to comment #10) > (From update of attachment 107602 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=107602&action=review > > > Source/WebCore/bindings/scripts/test/GObject/WebKitDOMTestCallback.cpp:235 > > -#endif /* ENABLE(DATABASE) */ > > +#endif // ENABLE(SQL_DATABASE) > > This change was incorrect, it broke binding test. > Fix landed in http://trac.webkit.org/changeset/95294 Thanks for fixing it, but I think that means the code generation script has a (minor!) bug. It should generate C++ style comments. /me will fix. GObject script fix in https://bugs.webkit.org/show_bug.cgi?id=68256 |