| Summary: | [Qt] QTouchWebView missing loadProgress tests | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Gopal Raghavan <gopal.1.raghavan> | ||||||
| Component: | WebKit2 | Assignee: | Nobody <webkit-unassigned> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | webkit.review.bot | ||||||
| Priority: | P2 | ||||||||
| Version: | 528+ (Nightly build) | ||||||||
| Hardware: | All | ||||||||
| OS: | All | ||||||||
| Attachments: |
|
||||||||
|
Description
Gopal Raghavan
2011-09-15 12:59:37 PDT
Created attachment 107535 [details]
TouchWebView loadProgress test
Added new tests to check loadProgress property of TouchWebView.
Here are the test results:
********* Start testing of qmltests *********
Config: Using QTest library 5.0.0, Qt 5.0.0
PASS : DesktopWebViewNavigationPolicyForUrl::initTestCase()
QWARN : DesktopWebViewNavigationPolicyForUrl::test_ignorePolicy() QObject::startTimer: timers cannot be started from another thread
PASS : DesktopWebViewNavigationPolicyForUrl::test_ignorePolicy()
PASS : DesktopWebViewNavigationPolicyForUrl::test_usePolicy()
PASS : DesktopWebViewNavigationPolicyForUrl::cleanupTestCase()
PASS : DesktopWebViewProperties::initTestCase()
QWARN : DesktopWebViewProperties::test_title() QSocketNotifier: socket notifiers cannot be enabled from another thread
QSocketNotifier: socket notifiers cannot be enabled from another thread
PASS : DesktopWebViewProperties::test_title()
PASS : DesktopWebViewProperties::test_url()
PASS : DesktopWebViewProperties::cleanupTestCase()
PASS : TouchWebViewLoad::initTestCase()
QWARN : TouchWebViewLoad::test_load() QSocketNotifier: socket notifiers cannot be enabled from another thread
QSocketNotifier: socket notifiers cannot be enabled from another thread
PASS : TouchWebViewLoad::test_load()
PASS : TouchWebViewLoad::cleanupTestCase()
PASS : TouchWebViewLoad::initTestCase()
QWARN : TouchWebViewLoad::test_loadNegativeSizeView() QSocketNotifier: socket notifiers cannot be enabled from another thread
QSocketNotifier: socket notifiers cannot be enabled from another thread
PASS : TouchWebViewLoad::test_loadNegativeSizeView()
PASS : TouchWebViewLoad::cleanupTestCase()
PASS : TouchWebViewLoadProgress::initTestCase()
QWARN : TouchWebViewLoadProgress::test_loadProgress() QSocketNotifier: socket notifiers cannot be enabled from another thread
QSocketNotifier: socket notifiers cannot be enabled from another thread
PASS : TouchWebViewLoadProgress::test_loadProgress()
PASS : TouchWebViewLoadProgress::cleanupTestCase()
PASS : TouchWebViewLoad::initTestCase()
QSocketNotifier: socket notifiers cannot be enabled from another thread
PASS : TouchWebViewLoad::test_loadZeroSizeView()
PASS : TouchWebViewLoad::cleanupTestCase()
PASS : TouchWebViewProperties::initTestCase()
QWARN : TouchWebViewProperties::test_title() QSocketNotifier: socket notifiers cannot be enabled from another thread
QSocketNotifier: socket notifiers cannot be enabled from another thread
PASS : TouchWebViewProperties::test_title()
PASS : TouchWebViewProperties::test_url()
PASS : TouchWebViewProperties::cleanupTestCase()
Totals: 24 passed, 0 failed, 0 skipped
********* Finished testing of qmltests *********
Number of leaked textures: 0
Number of leaked materials: 0
Number of leaked nodes: 0
LEAK: 7 WebContext
Number of leaked items: 0
Comment on attachment 107535 [details]
TouchWebView loadProgress test
LGTM.
Comment on attachment 107535 [details]
TouchWebView loadProgress test
Looks good. But please cleanup the format of the qml file. I think there are tabs in it.
Created attachment 107693 [details]
updated patch with reviewer comments
Chang, I have updated patch with format fixes. Thanks.
Comment on attachment 107693 [details]
updated patch with reviewer comments
Thanks!
Comment on attachment 107693 [details] updated patch with reviewer comments Clearing flags on attachment: 107693 Committed r95367: <http://trac.webkit.org/changeset/95367> All reviewed patches have been landed. Closing bug. |