Bug 68174

Summary: [Chromium] Add movementX/Y members to WebInputEvent
Product: WebKit Reporter: Vincent Scheib <scheib>
Component: New BugsAssignee: Vincent Scheib <scheib>
Status: RESOLVED FIXED    
Severity: Normal CC: dglazkov, webkit.review.bot, yzshen
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
fishd: review+, fishd: commit-queue-
Patch none

Description Vincent Scheib 2011-09-15 11:23:17 PDT
[Chromium] Add movementX/Y members to WebInputEvent
Comment 1 Vincent Scheib 2011-09-15 11:32:44 PDT
Created attachment 107518 [details]
Patch
Comment 2 Darin Fisher (:fishd, Google) 2011-09-15 23:03:42 PDT
Comment on attachment 107518 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=107518&action=review

> Source/WebKit/chromium/ChangeLog:3
> +        [Chromium] Add movementX/Y members to WebInputEvent

nit: This should say WebMouseEvent instead of WebInputEvent
Comment 3 Vincent Scheib 2011-09-16 07:44:17 PDT
Created attachment 107649 [details]
Patch
Comment 4 WebKit Review Bot 2011-09-16 07:46:39 PDT
Comment on attachment 107649 [details]
Patch

Rejecting attachment 107649 [details] from commit-queue.

scheib@chromium.org does not have committer permissions according to http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/committers.py.

- If you do not have committer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags.

- If you have committer rights please correct the error in Tools/Scripts/webkitpy/common/config/committers.py by adding yourself to the file (no review needed).  The commit-queue restarts itself every 2 hours.  After restart the commit-queue will correctly respect your committer rights.
Comment 5 WebKit Review Bot 2011-09-16 20:22:14 PDT
Comment on attachment 107649 [details]
Patch

Clearing flags on attachment: 107649

Committed r95359: <http://trac.webkit.org/changeset/95359>
Comment 6 WebKit Review Bot 2011-09-16 20:22:18 PDT
All reviewed patches have been landed.  Closing bug.