Bug 68174

Summary: [Chromium] Add movementX/Y members to WebInputEvent
Product: WebKit Reporter: Vincent Scheib <scheib>
Component: New BugsAssignee: Vincent Scheib <scheib>
Status: RESOLVED FIXED    
Severity: Normal CC: dglazkov, webkit.review.bot, yzshen
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
fishd: review+, fishd: commit-queue-
Patch none

Vincent Scheib
Reported 2011-09-15 11:23:17 PDT
[Chromium] Add movementX/Y members to WebInputEvent
Attachments
Patch (1.37 KB, patch)
2011-09-15 11:32 PDT, Vincent Scheib 		fishd: review+
fishd: commit-queue-
DetailsFormatted DiffDiff
Patch (1.41 KB, patch)
2011-09-16 07:44 PDT, Vincent Scheib 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Vincent Scheib
Comment 1 2011-09-15 11:32:44 PDT
Created attachment 107518 [details] Patch
Darin Fisher (:fishd, Google)
Comment 2 2011-09-15 23:03:42 PDT
Comment on attachment 107518 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=107518&action=review > Source/WebKit/chromium/ChangeLog:3 > + [Chromium] Add movementX/Y members to WebInputEvent nit: This should say WebMouseEvent instead of WebInputEvent
Vincent Scheib
Comment 3 2011-09-16 07:44:17 PDT
Created attachment 107649 [details] Patch
WebKit Review Bot
Comment 4 2011-09-16 07:46:39 PDT
Comment on attachment 107649 [details] Patch Rejecting attachment 107649 [details] from commit-queue. scheib@chromium.org does not have committer permissions according to http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/committers.py. - If you do not have committer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags. - If you have committer rights please correct the error in Tools/Scripts/webkitpy/common/config/committers.py by adding yourself to the file (no review needed). The commit-queue restarts itself every 2 hours. After restart the commit-queue will correctly respect your committer rights.
WebKit Review Bot
Comment 5 2011-09-16 20:22:14 PDT
Comment on attachment 107649 [details] Patch Clearing flags on attachment: 107649 Committed r95359: <http://trac.webkit.org/changeset/95359>
WebKit Review Bot
Comment 6 2011-09-16 20:22:18 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.