Bug 68148

Summary: Implement an ErrorEvent constructor for JSC
Product: WebKit Reporter: Kentaro Hara <haraken>
Component: DOMAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, ap, dominicc, sam, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 67824    
Attachments:
Description Flags
Patch
none
Patch
none
rebased patch for commit none

Description Kentaro Hara 2011-09-15 02:12:45 PDT 
ErrorEvent should have a constructor (Spec: http://dev.w3.org/html5/workers/#errorevent). 

After this patch is landed, I will add the ErrorEvent constructor for V8 as a follow-up patch.
Comment 1 Kentaro Hara 2011-09-15 04:11:08 PDT 
Created attachment 107475 [details]
Patch
Comment 2 Sam Weinig 2011-09-15 10:15:51 PDT 
Comment on attachment 107475 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=107475&action=review

> Source/WebCore/dom/ErrorEvent.h:78
> +    unsigned long m_lineNumber;

This should stay an unsigned int.  unsigned long in WebIDL maps to unsigned int in C.  Same with the the init.
Comment 3 Kentaro Hara 2011-09-15 11:23:16 PDT 
Created attachment 107515 [details]
Patch
Comment 4 Kentaro Hara 2011-09-15 23:14:40 PDT 
Created attachment 107609 [details]
rebased patch for commit
Comment 5 WebKit Review Bot 2011-09-16 19:00:35 PDT 
Comment on attachment 107609 [details]
rebased patch for commit

Clearing flags on attachment: 107609

Committed r95352: <http://trac.webkit.org/changeset/95352>
Comment 6 WebKit Review Bot 2011-09-16 19:00:40 PDT 
All reviewed patches have been landed.  Closing bug.