Bug 68144

Summary: Web Inspector: skip overlapping scripts when displaying concatenated content.
Product: WebKit Reporter: Pavel Podivilov <podivilov>
Component: Web Inspector (Deprecated)Assignee: Pavel Podivilov <podivilov>
Status: RESOLVED FIXED    
Severity: Normal CC: apavlov, bweinstein, joepeck, keishi, loislo, pfeldman, pmuellr, rik, timothy, yurys
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch pfeldman: review+

Pavel Podivilov
Reported 2011-09-15 00:32:41 PDT
Web Inspector: skip overlapping scripts when displaying concatenated content.
Attachments
Patch (5.54 KB, patch)
2011-09-15 00:37 PDT, Pavel Podivilov 		pfeldman: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Pavel Podivilov
Comment 1 2011-09-15 00:37:22 PDT
Created attachment 107471 [details] Patch
Pavel Feldman
Comment 2 2011-09-19 00:37:28 PDT
Comment on attachment 107471 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=107471&action=review > Source/WebCore/inspector/front-end/SourceFile.js:274 > + if (lineNumber > scripts[i].lineOffset || (lineNumber === scripts[i].lineOffset && columnNumber > scripts[i].columnOffset - scriptOpenTag.length)) Could you also investigate when this happens? I.e. can we process scripts added via appendChild differently?
Pavel Podivilov
Comment 3 2011-09-23 06:46:31 PDT
Committed r95797: <http://trac.webkit.org/changeset/95797>
Note You need to log in before you can comment on or make changes to this bug.