Summary: | [n]stricteq code is bogus in JSValue32_64 JIT | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Gavin Barraclough <barraclough> | ||||
Component: | JavaScriptCore | Assignee: | Nobody <webkit-unassigned> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | webkit.review.bot | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
Gavin Barraclough
2011-09-14 21:50:45 PDT
Created attachment 107453 [details]
The patch
Attachment 107453 [details] did not pass style-queue:
Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source..." exit_code: 1
Source/JavaScriptCore/ChangeLog:14: Need whitespace between colon and description [changelog/filechangedescriptionwhitespace] [5]
Source/JavaScriptCore/ChangeLog:15: Need whitespace between colon and description [changelog/filechangedescriptionwhitespace] [5]
Source/JavaScriptCore/ChangeLog:16: Need whitespace between colon and description [changelog/filechangedescriptionwhitespace] [5]
Total errors found: 3 in 2 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 107453 [details] The patch View in context: https://bugs.webkit.org/attachment.cgi?id=107453&action=review > Source/JavaScriptCore/jit/JITOpcodes32_64.cpp:1011 > + // Simply compare the patyloads. No patyloads here! Tyop! |