Summary: | REGRESSION(r95145): The GTK+ build is working now, so revert this trial build fix. (Requested by mrobinson on #webkit). | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | WebKit Review Bot <webkit.review.bot> | ||||
Component: | New Bugs | Assignee: | WebKit Review Bot <webkit.review.bot> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | andersca, thorton | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
WebKit Review Bot
2011-09-14 21:16:45 PDT
Created attachment 107449 [details] ROLLOUT of r95145 Any committer can land this patch automatically by marking it commit-queue+. The commit-queue will build and test the patch before landing to ensure that the rollout will be successful. This process takes approximately 15 minutes. If you would like to land the rollout faster, you can use the following command: webkit-patch land-attachment ATTACHMENT_ID where ATTACHMENT_ID is the ID of this attachment. Comment on attachment 107449 [details] ROLLOUT of r95145 Clearing flags on attachment: 107449 Committed r95162: <http://trac.webkit.org/changeset/95162> All reviewed patches have been landed. Closing bug. So, I'm still unable to build webkitgtk, and I just bisected the problem down to this commit. If I revert this change (effectively re-applying http://trac.webkit.org/changeset/95145), all is well. It looks like we're rolling over some sort of list-length limit or something!?! (i.e. I don't think it's related to the content of the files, just that we're making that list too long) I'm not really sure what's up, but I'm up for debugging at some point if anyone has any ideas... FWIW, I get a "GNUmakefile:66532: *** missing separator. Stop." When I look at that line, I see: maintainer-clean: maintainer-clean-am -rm -f $(am__CONFIG_DISTCLEAN_FILES) -rm -rf $(top_srcdir)/autom4te.cache urce/WebKit2/WebProcess/Downloads/soup/$(DEPDIR) Source/WebKit2/WebProcess/FullScre [CONTINUED for quite a while] -rm -f GNUmakefile Note that that line (66532) there a) is not indented and b) complete garbage, appearing to be truncated at the beginning. |