Bug 68137

Summary: Use isAcceleratedContext() on the GraphicsContext instead of flags in ImageBuffer
Product: WebKit Reporter: Matthew Delaney <mdelaney7>
Component: CanvasAssignee: Matthew Delaney <mdelaney7>
Status: RESOLVED FIXED    
Severity: Normal CC: caseq, cmarrin, jamesr, kbr, mdelaney7, senorblanco, simon.fraser
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 68146    
Bug Blocks: 68041    
Attachments:
Description Flags
Patch simon.fraser: review+

Matthew Delaney
Reported 2011-09-14 20:31:16 PDT
The m_acceleratesRendering flag on ImageBuffer is no longer needed. Using the flag on the graphics context via isAcceleratedContext and setIsAcceleratedContext is sufficient and cleaner.
Attachments
Patch (10.39 KB, patch)
2011-09-14 20:37 PDT, Matthew Delaney 		simon.fraser: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Matthew Delaney
Comment 1 2011-09-14 20:37:32 PDT
Created attachment 107447 [details] Patch
Matthew Delaney
Comment 2 2011-09-14 23:54:48 PDT
Committed r95174: <http://trac.webkit.org/changeset/95174>
Andrey Kosyakov
Comment 3 2011-09-15 00:52:27 PDT
(In reply to comment #2) > Committed r95174: <http://trac.webkit.org/changeset/95174> This broke chromium build, e.g.: http://build.chromium.org/p/chromium.webkit/builders/Webkit%20Win7/builds/7574/steps/compile/logs/stdio >..\platform\graphics\skia\ImageBufferSkia.cpp(103) : error C2039: 'setIsAcceleratedContext' : is not a member of 'WebCore::GraphicsContext' 5> e:\b\build\slave\Webkit_Win7\build\src\third_party\WebKit\Source\WebCore\platform\graphics\GraphicsContext.h(215) : see declaration of 'WebCore::GraphicsContext'
Note You need to log in before you can comment on or make changes to this bug.