Bug 6813

Summary: elementAtPoint needs to return input element when clicking on new text field
Product: WebKit Reporter: Adele Peterson <adele>
Component: FormsAssignee: Adele Peterson <adele>
Status: RESOLVED FIXED    
Severity: Normal Keywords: InRadar
Priority: P2    
Version: 420+   
Hardware: Mac   
OS: OS X 10.4   
Bug Depends on:    
Bug Blocks: 6986    
Attachments:
Description Flags
patch darin: review+

Adele Peterson
Reported 2006-01-25 18:40:22 PST
Right now, elementAtPoint will return the inner div. You can see this by trying to use the Web Inspector on the new text field.
Attachments
patch (29.15 KB, patch)
2006-03-21 15:10 PST, Adele Peterson 		darin: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Darin Adler
Comment 1 2006-01-28 17:12:38 PST
These bugs that block us switching to the new text field shoul not be marked P1. Once we turn it on, these would be P1/major bugs, of course, but at the moment they are just part of the "switch to a new text field" task and should not be in the P1 list.
Adele Peterson
Comment 2 2006-03-01 16:59:16 PST
<rdar://problem/4463754> elementAtPoint needs to return input element when clicking on new text field (6813)
Adele Peterson
Comment 3 2006-03-21 15:10:17 PST
Created attachment 7223 [details] patch
Darin Adler
Comment 4 2006-03-21 15:47:28 PST
Comment on attachment 7223 [details] patch isShadowNode() oughta be const. _actionInformationForNavigationType should probably pass NO for allowShadowContent. Places that check isTextNode and call parentNode might result in nil, and then you are calling shadowAncestorNode without a nil check. Looks great. r=me
Note You need to log in before you can comment on or make changes to this bug.