Bug 68118

Summary:

DFG should not speculate that the child of LogicalNot is a boolean if predictions tell us otherwise

Product:

WebKit

Reporter:

Filip Pizlo <fpizlo>

Component:

JavaScriptCore

Assignee:

Filip Pizlo <fpizlo>

Status:

RESOLVED INVALID

Severity:

Normal

CC:

eric

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
the patch	fpizlo: review-

Description Filip Pizlo 2011-09-14 14:16:36 PDT

The DFG JIT currently speculates that all LogicalNots always operate over booleans even when they clearly don't.  Value profiling can tell us if the input value is not a boolean, and we should take advantage of this information.

Comment 1 Filip Pizlo 2011-09-14 14:17:49 PDT

Created attachment 107393 [details]
the patch

Comment 2 Geoffrey Garen 2011-09-14 14:22:36 PDT

Comment on attachment 107393 [details]
the patch

r=me

Comment 3 Eric Seidel (no email) 2011-12-21 14:30:14 PST

Attachment 107393 [details] was posted by a committer and has review+, assigning to Filip Pizlo for commit.

Comment 4 Filip Pizlo 2011-12-21 14:34:36 PST

Comment on attachment 107393 [details]
the patch

This patch is stale and has been superseded.