Bug 68114 – [Qt] Replace QT_GCC_X as they don't exist in Qt5 anymore.

• Component: WebKit Qt
• Status: RESOLVED FIXED

[Alexis Menard (darktears)]

[Qt] Replace QT_GCC_X as they don't exist in Qt5 anymore.

[Alexis Menard (darktears)]

Created attachment 107392 [details]
Patch

[Kenneth Rohde Christiansen]

Comment on attachment 107392 [details]
Patch

Ok, I trust you on this one

[WebKit Review Bot]

Comment on attachment 107392 [details]
Patch

Clearing flags on attachment: 107392

Committed r95163: <http://trac.webkit.org/changeset/95163>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.

[Simon Hausmann]

Comment on attachment 107392 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=107392&action=review

> ChangeLog:3
> +        [Qt] Replace QT_GCC_X as they don't exist in Qt5 anymore.

Hang on, I think this was a mistake. Commit 7493ee1c44a16dc3b155a5bf3ed7ca966a71072a in qtbase accidentally removed
these qmake variables.

> Source/WebKit.pri:99
> +    GCC_VERSION = $$system(gcc -dumpversion)
> +    GCC_VERSION = $$split(GCC_VERSION, ".")

This seems wrong to me in the context of cross compilation.

[Simon Hausmann]

I submitted http://paste.ubuntu.com/689876/ for review and inclusion into qtbase. Once that change is in, then I think we should back out r95163.

[Alexis Menard (darktears)]

(In reply to comment #6)
> I submitted http://paste.ubuntu.com/689876/ for review and inclusion into qtbase. Once that change is in, then I think we should back out r95163.

I tried to get brad with no success. Btw his patch was submitted reviewed by himself :D.

Still it is semantically wrong, QT_GCC_X tells you which compiler version Qt was built, not the one you are actually building.

I haven't though about the context of cross compilation can we get the compiler path in qmake? I mean the one that will be used to compile so I can invoke that variable rather than "gcc"?

[Simon Hausmann]

(In reply to comment #7)
> (In reply to comment #6)
> > I submitted http://paste.ubuntu.com/689876/ for review and inclusion into qtbase. Once that change is in, then I think we should back out r95163.
> 
> I tried to get brad with no success. Btw his patch was submitted reviewed by himself :D.
> 
> Still it is semantically wrong, QT_GCC_X tells you which compiler version Qt was built, not the one you are actually building.

I think it is correct, because qmake doesn't really support using one compiler for Qt and another one for apps. There's only host compilers for some host tools in Qt and then _the_ target compiler.

Differently put: I don't think we should bother about any other setups :)

> I haven't though about the context of cross compilation can we get the compiler path in qmake? I mean the one that will be used to compile so I can invoke that variable rather than "gcc"?

QMAKE_CC and QMAKE_CXX would be correct. But you'd have to duplicate what configure is doing (check if it's gcc, distinguish between major and minor releases in the output). Is it really worth it? :)

[Simon Hausmann]

The Qt fix went in and is now on Gitorious: http://qt.gitorious.org/qt/qtbase/commit/80d406ce39d23ec6c859b9aa427dee8d0d3c9d50