Bug 68080

Summary: query SystemParametersInfo for GDI font smoothing settings
Product: WebKit Reporter: Mike Reed <reed>
Component: New BugsAssignee: Mike Reed <reed>
Status: RESOLVED FIXED    
Severity: Normal CC: jamesr, kbr, senorblanco, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Mike Reed
Reported 2011-09-14 08:13:43 PDT
query SystemParametersInfo for GDI font smoothing settings
Attachments
Patch (3.23 KB, patch)
2011-09-14 08:16 PDT, Mike Reed 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Mike Reed
Comment 1 2011-09-14 08:16:07 PDT
Created attachment 107332 [details] Patch
Stephen White
Comment 2 2011-09-14 08:58:17 PDT
Comment on attachment 107332 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=107332&action=review Looks good. r=me > Source/WebCore/platform/graphics/skia/SkiaFontWin.cpp:108 > + static bool gInited; > + static uint32_t gFlags; Nit: since gFlags is a function-level static anyway, if you wanted, you could save the gInited bool by refactoring the initialization into another function and doing: static uint32_t gFlags = getTextFlagsFromGDI(); return gFlags; Of course, a new function to save a bool, maybe not worth it. :)
WebKit Review Bot
Comment 3 2011-09-14 10:03:19 PDT
Comment on attachment 107332 [details] Patch Clearing flags on attachment: 107332 Committed r95097: <http://trac.webkit.org/changeset/95097>
WebKit Review Bot
Comment 4 2011-09-14 10:03:23 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.