Summary: | committers.py is missing some contributors | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Ryosuke Niwa <rniwa> | ||||||
Component: | Tools / Tests | Assignee: | Ryosuke Niwa <rniwa> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | abarth, alex, ap, collinj, davidbarr, dev+webkit, eric, jhanssen, kim.1.gronholm | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Bug Depends on: | |||||||||
Bug Blocks: | 68045 | ||||||||
Attachments: |
|
Description
Ryosuke Niwa
2011-09-13 23:39:47 PDT
Created attachment 107294 [details]
updates committers.py
Comment on attachment 107294 [details]
updates committers.py
More stuff to add :(
Created attachment 107295 [details]
updates committers.py
Thanks for the review! Committed r95078: <http://trac.webkit.org/changeset/95078> Comment on attachment 107295 [details] updates committers.py View in context: https://bugs.webkit.org/attachment.cgi?id=107295&action=review > Tools/Scripts/webkitpy/common/config/committers.py:229 > + Committer(u"Kim Gr\u00f6nholm", "kim.1.gronholm@nokia.com"), Do we know that these people actually became committers and weren't just invited? Comment on attachment 107295 [details] updates committers.py View in context: https://bugs.webkit.org/attachment.cgi?id=107295&action=review > Tools/Scripts/webkitpy/common/config/committers.py:200 > + Committer("Jan Erik Hanssen", "jhanssen@sencha.com", "jehanssen"), Normally folks add themselves to the committers file, that makes it easy to tell that their actually committers. The validate-committer-list script in Tools/Scripts can of course compare with the git/svn history and validate thsi for us of course. (In reply to comment #7) > Normally folks add themselves to the committers file, that makes it easy to tell that their actually committers. The validate-committer-list script in Tools/Scripts can of course compare with the git/svn history and validate thsi for us of course. I've manually looked through trac to make sure they've committed something in the past :) Could you please post a link to a trac entry for a Jan Erik's commit? I cannot find one. (In reply to comment #9) > Could you please post a link to a trac entry for a Jan Erik's commit? I cannot find one. You're right, he has been invited to committers but hasn't made any manual commits yet. I'm removing him from the list for now. |