Bug 68056

Summary: MediaPlayerPrivateAVFoundationObjC's "periodic time observer" is unnecessary
Product: WebKit Reporter: Eric Carlson <eric.carlson>
Component: MediaAssignee: Eric Carlson <eric.carlson>
Status: RESOLVED FIXED    
Severity: Normal CC: webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: Mac   
OS: OS X 10.6   
Attachments:
Description Flags
Proposed patch. darin: review+

Description Eric Carlson 2011-09-13 21:42:45 PDT
MediaPlayerPrivateAVFoundationObjC::createAVPlayer creates a periodic time observer that fires once in a very long while just so it can also be called whenever the time is changed. This was originally necessary early on, but AVPlayerItem's -seekToTime:toleranceBefore:toleranceAfter:completionHandler makes it completely unnecessary.
Comment 1 Radar WebKit Bug Importer 2011-09-13 21:43:37 PDT
<rdar://problem/10121225>
Comment 2 Eric Carlson 2011-09-13 22:07:12 PDT
Created attachment 107286 [details]
Proposed patch.
Comment 3 Darin Adler 2011-09-13 22:14:46 PDT
Comment on attachment 107286 [details]
Proposed patch.

Patch would be better if it explained why we thought it was needed, what changed, and so why it’s not needed now.
Comment 4 Eric Carlson 2011-09-14 11:59:36 PDT
 http://trac.webkit.org/changeset/95104