Bug 68047

Summary: OS(QNX) builds with threads turned off
Product: WebKit Reporter: Geoffrey Garen <ggaren>
Component: JavaScriptCoreAssignee: Eli Fidler <efidler>
Status: RESOLVED FIXED    
Severity: Normal CC: dbates, efidler, staikos, tonikitoo, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Description Geoffrey Garen 2011-09-13 18:20:14 PDT 
Per email to webkit-dev, we're going to remove the "no threads" #ifdefs from JavaScriptCore and WebKit. Please update the OS(QNX) platform to be compatible with this change.

Try this, in Platform.h:

Unconditionally set ENABLE_SINGLE_THREADED=0.
Unconditionally set ENABLE_JSC_MULTIPLE_THREADS=1.
Unconditionally set ENABLE_WTF_MULTIPLE_THREADS=1.

Build and see what happens.
Comment 1 Eli Fidler 2011-09-14 11:43:34 PDT 
Created attachment 107364 [details]
Patch
Comment 2 WebKit Review Bot 2011-09-15 08:47:42 PDT 
Comment on attachment 107364 [details]
Patch

Rejecting attachment 107364 [details] from commit-queue.

efidler@rim.com does not have committer permissions according to http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/committers.py.

- If you do not have committer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags.

- If you have committer rights please correct the error in Tools/Scripts/webkitpy/common/config/committers.py by adding yourself to the file (no review needed).  The commit-queue restarts itself every 2 hours.  After restart the commit-queue will correctly respect your committer rights.
Comment 3 WebKit Review Bot 2011-09-15 09:48:18 PDT 
Comment on attachment 107364 [details]
Patch

Rejecting attachment 107364 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2

Last 500 characters of output:
k #4 succeeded at 367 with fuzz 1.
Hunk #5 FAILED at 429.
Hunk #6 succeeded at 453 (offset 10 lines).
1 out of 6 hunks FAILED -- saving rejects to file Source/JavaScriptCore/heap/MachineStackMarker.cpp.rej
patching file Source/JavaScriptCore/wtf/Platform.h
Hunk #1 FAILED at 588.
1 out of 1 hunk FAILED -- saving rejects to file Source/JavaScriptCore/wtf/Platform.h.rej

Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--reviewer', u'Sam Weinig', u'--force']" exit_code: 1

Full output: http://queues.webkit.org/results/9694068
Comment 4 Antonio Gomes 2011-09-15 09:49:24 PDT 
(In reply to comment #2)
> (From update of attachment 107364 [details])
> Rejecting attachment 107364 [details] from commit-queue.
> 
> efidler@rim.com does not have committer permissions according to http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/committers.py.
> 
> - If you do not have committer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags.
> 
> - If you have committer rights please correct the error in Tools/Scripts/webkitpy/common/config/committers.py by adding yourself to the file (no review needed).  The commit-queue restarts itself every 2 hours.  After restart the commit-queue will correctly respect your committer rights.


Eli, we can easily fix it. Upload a patch that adds your @rim.com email to committers.py, and cq? it. I can cq+ and you will be able to cq+ patches yourself.

> Last 500 characters of output:
> k #4 succeeded at 367 with fuzz 1.
> Hunk #5 FAILED at 429.
> Hunk #6 succeeded at 453 (offset 10 lines).
> 1 out of 6 hunks FAILED -- saving rejects to file Source/JavaScriptCore/heap/MachineStackMarker.cpp.rej
> patching file Source/JavaScriptCore/wtf/Platform.h
> Hunk #1 FAILED at 588.
> 1 out of 1 hunk FAILED -- saving rejects to file Source/JavaScriptCore/wtf/Platform.h.rej
> 
> Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--reviewer', u'Sam Weinig', u'--force']" exit_code: 1
> 
> Full output: http://queues.webkit.org/results/9694068


btw, you patch does not apply to trunk clearly it seems.
Comment 5 Eli Fidler 2011-09-15 10:44:49 PDT 
I'll rebase the patch.
Comment 6 Eli Fidler 2011-09-19 14:05:45 PDT 
Created attachment 107917 [details]
Patch
Comment 7 Geoffrey Garen 2011-09-19 14:29:13 PDT 
Comment on attachment 107917 [details]
Patch

This patch doesn't seem to turn on threads for QNX. How did you test it?
Comment 8 Eli Fidler 2011-09-19 15:35:58 PDT 
Your patch in r94871 enabled JSC_MULTIPLE_THREADS unconditionally, so our build is broken without this patch. There's no OS(QNX) build system upstream yet, so you probably couldn't know this.
Comment 9 Eli Fidler 2011-09-19 15:47:28 PDT 
Created attachment 107935 [details]
Patch
Comment 10 Daniel Bates 2011-09-19 15:49:58 PDT 
Comment on attachment 107935 [details]
Patch

This patch now enables PThread support on QNX.

r=me
Comment 11 WebKit Review Bot 2011-09-19 17:34:46 PDT 
Comment on attachment 107935 [details]
Patch

Clearing flags on attachment: 107935

Committed r95498: <http://trac.webkit.org/changeset/95498>
Comment 12 WebKit Review Bot 2011-09-19 17:34:51 PDT 
All reviewed patches have been landed.  Closing bug.