Bug 68038

Summary:

Media element tests should look up controller element locations

Product:

WebKit

Reporter:

Eric Carlson <eric.carlson>

Component:

Media

Assignee:

Eric Carlson <eric.carlson>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

abarth, dglazkov, webkit.review.bot

Priority:

Keywords:

InRadar

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Bug Depends on:

68034

Bug Blocks:

Attachments:

Description	Flags
Proposed patch.	darin: review+, webkit.review.bot: commit-queue-

Eric Carlson

Reported 2011-09-13 16:06:56 PDT

Some media element layout tests still make assumptions about the location of the default controls. They should not.

Attachments
Proposed patch. (10.46 KB, patch) 2011-09-13 16:35 PDT, Eric Carlson	darin: review+ webkit.review.bot: commit-queue-	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Eric Carlson

Comment 1 2011-09-13 16:35:25 PDT

Created attachment 107255 [details] Proposed patch.

Eric Carlson

Comment 2 2011-09-13 16:38:47 PDT

<rdar://problem/7499935>

WebKit Review Bot

Comment 3 2011-09-13 18:40:42 PDT

Comment on attachment 107255 [details] Proposed patch. Attachment 107255 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/9654395 New failing tests: platform/chromium/fast/text/text-stroke-with-border.html media/controls-drag-timebar.html scrollbars/disabled-scrollbar.html printing/return-from-printing-mode.html media/controls-right-click-on-timebar.html scrollbars/listbox-scrollbar-combinations.html platform/mac-snowleopard/platform/mac/fast/text/international/Geeza-Pro-vertical-metrics-adjustment.html scrollbars/overflow-scrollbar-combinations.html scrollbars/basic-scrollbar.html media/audio-delete-while-slider-thumb-clicked.html

Eric Carlson

Comment 4 2011-09-13 19:58:57 PDT

(In reply to comment #3) > (From update of attachment 107255 [details]) > Attachment 107255 [details] did not pass chromium-ews (chromium-xvfb): > Output: http://queues.webkit.org/results/9654395 > > New failing tests: > platform/chromium/fast/text/text-stroke-with-border.html > media/controls-drag-timebar.html > scrollbars/disabled-scrollbar.html > printing/return-from-printing-mode.html > media/controls-right-click-on-timebar.html > scrollbars/listbox-scrollbar-combinations.html > platform/mac-snowleopard/platform/mac/fast/text/international/Geeza-Pro-vertical-metrics-adjustment.html > scrollbars/overflow-scrollbar-combinations.html > scrollbars/basic-scrollbar.html > media/audio-delete-while-slider-thumb-clicked.html I call BS on most of these "new failing tests", it isn't possible for changes in html files in LayoutTests/media/ to break tests in other directories. The warnings about media/controls-right-click-on-timebar.html and media/audio-delete-while-slider-thumb-clicked.htm are legitimate because they won't work without https://bugs.webkit.org/show_bug.cgi?id=68034.

Adam Barth

Comment 5 2011-09-13 22:29:46 PDT

> I call BS on most of these "new failing tests" Thanks. We probably have a problem where we're reporting failures that occur even without your patch.

Eric Carlson

Comment 6 2011-09-14 15:44:07 PDT

http://trac.webkit.org/changeset/95133

Note You need to log in before you can comment on or make changes to this bug.