Bug 68025

Summary: Move identifier filter from CSSStyleSelector to SelectorChecker
Product: WebKit Reporter: Antti Koivisto <koivisto>
Component: CSSAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: hyatt, rolandsteiner, sam, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
patch sam: review+

Antti Koivisto
Reported 2011-09-13 14:20:37 PDT
This is a more logical place for this code (and also makes CSSStyleSelector slightly less bloated). It will make it possible to use fastRejectSelector for querySelectoAll in the future.
Attachments
patch (20.77 KB, patch)
2011-09-13 14:34 PDT, Antti Koivisto 		sam: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Antti Koivisto
Comment 1 2011-09-13 14:34:00 PDT
Created attachment 107230 [details] patch
WebKit Review Bot
Comment 2 2011-09-13 14:36:29 PDT
Attachment 107230 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1 Source/WebCore/css/SelectorChecker.h:63: The parameter name "selector" adds no information, so it should be removed. [readability/parameter_name] [5] Source/WebCore/css/SelectorChecker.cpp:186: A case label should not be indented, but line up with its switch statement. [whitespace/indent] [4] Total errors found: 2 in 5 files If any of these errors are false positives, please file a bug against check-webkit-style.
Antti Koivisto
Comment 3 2011-09-13 15:38:36 PDT
http://trac.webkit.org/changeset/95052
Note You need to log in before you can comment on or make changes to this bug.