Bug 68015

Summary: [v8] Improve performance of typed array copy constructor taking Array
Product: WebKit Reporter: Ulan Degenbaev <ulan>
Component: WebGLAssignee: Ulan Degenbaev <ulan>
Status: RESOLVED FIXED    
Severity: Normal CC: kbr, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 68237    
Attachments:
Description Flags
Invoke the 'set' method of the constructed array
none
Fix style error (include primary header) and include ExceptionCode.h in V8ArrayBufferViewCustom.h none

Description Ulan Degenbaev 2011-09-13 11:48:06 PDT 
This issue is related to https://bugs.webkit.org/show_bug.cgi?id=63644 . The copy constructor copies elements of the source array one by one using the V8 API  functions, which produces many context switches the WebKit and the V8. We can speed it up by invoking the 'set' method of the constructed array in JavaScript.
Comment 1 Ulan Degenbaev 2011-09-13 12:17:20 PDT 
Created attachment 107209 [details]
Invoke the 'set' method of the constructed array
Comment 2 WebKit Review Bot 2011-09-13 12:20:51 PDT 
Attachment 107209 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'ChangeLog', u'Source/WebCore/WebCore.gypi'..." exit_code: 1

Source/WebCore/bindings/v8/custom/V8ArrayBufferViewCustom.cpp:28:  Found other header before a header this file implements. Should be: config.h, primary header, blank line, and then alphabetically sorted.  [build/include_order] [4]
Total errors found: 1 in 4 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Ulan Degenbaev 2011-09-13 12:47:14 PDT 
Created attachment 107212 [details]
Fix style error (include primary header) and include ExceptionCode.h in V8ArrayBufferViewCustom.h
Comment 4 Kenneth Russell 2011-09-14 11:48:28 PDT 
Comment on attachment 107212 [details]
Fix style error (include primary header) and include ExceptionCode.h in V8ArrayBufferViewCustom.h

Thanks, looks good. r=me
Comment 5 WebKit Review Bot 2011-09-14 20:27:49 PDT 
Comment on attachment 107212 [details]
Fix style error (include primary header) and include ExceptionCode.h in V8ArrayBufferViewCustom.h

Clearing flags on attachment: 107212

Committed r95157: <http://trac.webkit.org/changeset/95157>
Comment 6 WebKit Review Bot 2011-09-14 20:27:53 PDT 
All reviewed patches have been landed.  Closing bug.