Bug 68003

Summary: UpdateChangeLogsWithReviewer should be able to determine reviewer of latest reviewed patch in a bug
Product: WebKit Reporter: WebKit Review Bot <webkit.review.bot>
Component: New BugsAssignee: Tom Zakrajsek <tomz>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, eric, tomz
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

WebKit Review Bot
Reported 2011-09-13 07:28:56 PDT
UpdateChangeLogsWithReviewer should be able to determine reviewer of latest reviewed patch in a bug Requested by tomz on #webkit.
Attachments
Patch (4.40 KB, patch)
2011-09-14 15:29 PDT, Tom Zakrajsek 		no flags
DetailsFormatted DiffDiff
Patch (4.70 KB, patch)
2011-09-15 14:06 PDT, Tom Zakrajsek 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Tom Zakrajsek
Comment 1 2011-09-14 15:29:37 PDT
Created attachment 107405 [details] Patch
Adam Barth
Comment 2 2011-09-14 15:43:46 PDT
Comment on attachment 107405 [details] Patch Nice idea.
Adam Barth
Comment 3 2011-09-14 15:44:09 PDT
Comment on attachment 107405 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=107405&action=review > Tools/Scripts/webkitpy/tool/steps/updatechangelogswithreviewer.py:50 > - patch = patches[0] > + patch = patches[len(patches) - 1] In Python, you can just write patches[-1]
Eric Seidel (no email)
Comment 4 2011-09-14 15:55:07 PDT
Comment on attachment 107405 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=107405&action=review > Tools/Scripts/webkitpy/tool/steps/updatechangelogswithreviewer.py:47 > + if len(patches) < 1: This could also be "not patches"
Tom Zakrajsek
Comment 5 2011-09-15 14:06:32 PDT
Created attachment 107548 [details] Patch
Tom Zakrajsek
Comment 6 2011-09-15 14:08:07 PDT
Implemented idiomatic improvements suggested by Adam and Eric. Thanks guys.
WebKit Review Bot
Comment 7 2011-09-15 19:02:25 PDT
Comment on attachment 107548 [details] Patch Clearing flags on attachment: 107548 Committed r95257: <http://trac.webkit.org/changeset/95257>
WebKit Review Bot
Comment 8 2011-09-15 19:02:34 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.