|Summary:||Possible ASSERT(!storageTracker) in Lazily Initialized StorageTracker|
|Product:||WebKit||Reporter:||Joseph Pecoraro <joepeck>|
|Component:||WebCore Misc.||Assignee:||Joseph Pecoraro <joepeck>|
|Severity:||Normal||CC:||ap, beidson, joepeck, webkit.review.bot|
|Version:||528+ (Nightly build)|
Description Joseph Pecoraro 2011-09-12 15:14:09 PDT
StorageTracker::initializeTracker ASSERTs: ASSERT(!storageTracker); However that global static could have been initialized by a call to StorageTracker::tracker. We should instead ASSERT that the tracker doesn't exist yet (we create it here) or if it does exist that it doesn't yet have a client (which is what initialize is doing).
Comment 1 Joseph Pecoraro 2011-09-12 16:37:47 PDT
Created attachment 107110 [details] [PATCH] Proposed Fix
Comment 3 Darin Adler 2011-09-12 16:46:19 PDT
Comment on attachment 107110 [details] [PATCH] Proposed Fix Seems fine.
Comment 4 WebKit Review Bot 2011-09-12 21:40:49 PDT
Comment on attachment 107110 [details] [PATCH] Proposed Fix Clearing flags on attachment: 107110 Committed r95013: <http://trac.webkit.org/changeset/95013>
Comment 5 WebKit Review Bot 2011-09-12 21:40:53 PDT
All reviewed patches have been landed. Closing bug.