Bug 67956

Summary: DFG JIT always speculates that ValueAdd is a numeric addition
Product: WebKit Reporter: Filip Pizlo <fpizlo>
Component: JavaScriptCoreAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: barraclough, fpizlo, oliver
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
the patch
ggaren: review+, webkit-ews: commit-queue-
the patch - disable tiering none

Filip Pizlo
Reported 2011-09-12 15:10:28 PDT
DFG JIT always speculates that ValueAdd is a numerical addition even when there is evidence to the contrary. This causes all uses of "+" for string concatenation to fall off the speculative path.
Attachments
the patch (9.61 KB, patch)
2011-09-12 15:45 PDT, Filip Pizlo 		ggaren: review+
webkit-ews: commit-queue-
DetailsFormatted DiffDiff
the patch - disable tiering (9.16 KB, patch)
2011-09-12 16:17 PDT, Filip Pizlo 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Filip Pizlo
Comment 1 2011-09-12 15:45:30 PDT
Created attachment 107095 [details] the patch
Geoffrey Garen
Comment 2 2011-09-12 15:50:19 PDT
Comment on attachment 107095 [details] the patch View in context: https://bugs.webkit.org/attachment.cgi?id=107095&action=review r=me > Source/JavaScriptCore/wtf/Platform.h:968 > -#define ENABLE_TIERED_COMPILATION 0 > +#define ENABLE_TIERED_COMPILATION 1 Oops?
Early Warning System Bot
Comment 3 2011-09-12 16:02:47 PDT
Comment on attachment 107095 [details] the patch Attachment 107095 [details] did not pass qt-ews (qt): Output: http://queues.webkit.org/results/9649142
Filip Pizlo
Comment 4 2011-09-12 16:11:49 PDT
(In reply to comment #2) > (From update of attachment 107095 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=107095&action=review > > r=me > > > Source/JavaScriptCore/wtf/Platform.h:968 > > -#define ENABLE_TIERED_COMPILATION 0 > > +#define ENABLE_TIERED_COMPILATION 1 > > Oops? Oops indeed!
Filip Pizlo
Comment 5 2011-09-12 16:17:52 PDT
Created attachment 107103 [details] the patch - disable tiering Will wait for bots before committing.
Filip Pizlo
Comment 6 2011-09-12 16:54:25 PDT
It's probably best to land this after the OSR patches land. Leaving it up here until then.
Filip Pizlo
Comment 7 2011-09-14 19:02:44 PDT
Landed in r95147.
Note You need to log in before you can comment on or make changes to this bug.