Bug 67932

Summary: Web Inspector: event dividers do not update timeline boundaries.
Product: WebKit Reporter: Pavel Feldman <pfeldman>
Component: Web Inspector (Deprecated)Assignee: Pavel Feldman <pfeldman>
Status: RESOLVED FIXED    
Severity: Normal CC: apavlov, bweinstein, joepeck, keishi, loislo, pfeldman, pmuellr, rik, timothy, yurys
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch tonyg: review+

Description Pavel Feldman 2011-09-12 06:32:51 PDT
Events (as resources) should update timeline boundaries.
Comment 1 Pavel Feldman 2011-09-12 06:34:42 PDT
Created attachment 107048 [details]
Patch
Comment 2 Ilya Tikhonovsky 2011-09-12 07:33:16 PDT
Comment on attachment 107048 [details]
Patch

LGTM
Comment 3 Tony Gentilcore 2011-09-12 08:03:59 PDT
Comment on attachment 107048 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=107048&action=review

> Source/WebCore/inspector/front-end/NetworkPanel.js:630
> +        // Schedule refresh to update boundaries and draw the new line.

Up to you, but both of these comments seem a bit gratuitous. They don't convey much more info than the method name.

> Source/WebCore/inspector/front-end/NetworkPanel.js:667
> +            boundariesChanged = this.calculator.updateBoundariesForEventTime(this._mainResourceDOMContentTime) || boundariesChanged;

Cleaner to use |= for these two, right?
Comment 4 Pavel Feldman 2011-09-12 08:19:29 PDT
Comment on attachment 107048 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=107048&action=review

>> Source/WebCore/inspector/front-end/NetworkPanel.js:667
>> +            boundariesChanged = this.calculator.updateBoundariesForEventTime(this._mainResourceDOMContentTime) || boundariesChanged;
> 
> Cleaner to use |= for these two, right?

Not really:
- |= is bitwise operator
- I need boundaries to be updated even when boundariesChanged is true.
Comment 5 Pavel Feldman 2011-09-12 08:21:42 PDT
Committed r94957: <http://trac.webkit.org/changeset/94957>