Bug 67928

Summary:

[Qt] Build fails after r94920 with strict compiler

Product:

WebKit

Reporter:

Andras Becsi <abecsi>

Component:

Tools / Tests

Assignee:

Andras Becsi <abecsi>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

cmarcelo, ossy

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

Linux

Bug Depends on:

Bug Blocks:

43191

Attachments:

Description	Flags
proposed fix	cmarcelo: review-
proposed patch	none

Description Andras Becsi 2011-09-12 03:56:04 PDT

The newly added wtf/RedBlackTree.h contains the variable Node* updateStart which is set but never used. This gives an error on newer gcc when Werror is set. Remove this dead variable.

Comment 1 Andras Becsi 2011-09-12 03:59:23 PDT

Created attachment 107036 [details]
proposed fix

Comment 2 Caio Marcelo de Oliveira Filho 2011-09-12 04:49:20 PDT

LGTM, although I'm not a reviewer.

New Red Black tree is based on PODRedBlackTree.h. The 'updateStart' variable was used to call 'updateNode' on the ascendants of the topmost updated node. The new one (RedBlackTree.h) doesn't have this functionality, so it is OK to remove.

Comment 3 Caio Marcelo de Oliveira Filho 2011-09-12 05:00:14 PDT

Comment on attachment 107036 [details]
proposed fix

View in context: https://bugs.webkit.org/attachment.cgi?id=107036&action=review

Ops. Doesn't LGTM yet :P

> Source/JavaScriptCore/wtf/RedBlackTree.h:-196
> -                    Node* newSubTreeRoot = rightRotate(x->parent()->parent());

You need to keep this rightRotate, just ignore the return value.

> Source/JavaScriptCore/wtf/RedBlackTree.h:-218
> -                    Node* newSubTreeRoot = leftRotate(x->parent()->parent());

You need to keep this leftRotate, just ignore the return value.

Comment 4 Andras Becsi 2011-09-12 06:06:50 PDT

Created attachment 107043 [details]
proposed patch

Comment 5 Csaba Osztrogonác 2011-09-12 06:24:56 PDT

Comment on attachment 107043 [details]
proposed patch

LGTM, r=me. ( But cq-, because commit queue still doesn't like my name :( )

Comment 6 Andras Becsi 2011-09-12 06:33:14 PDT

Committed r94954: <http://trac.webkit.org/changeset/94954>

Comment 7 Andras Becsi 2011-09-12 06:34:16 PDT

Comment on attachment 107043 [details]
proposed patch

Clearing flags from landed patch.