Bug 67928

Summary:

[Qt] Build fails after r94920 with strict compiler

Product:

WebKit

Reporter:

Andras Becsi <abecsi>

Component:

Tools / Tests

Assignee:

Andras Becsi <abecsi>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

cmarcelo, ossy

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

Linux

Bug Depends on:

Bug Blocks:

43191

Attachments:

Description	Flags
proposed fix	cmarcelo: review-
proposed patch	none

Andras Becsi

Reported 2011-09-12 03:56:04 PDT

The newly added wtf/RedBlackTree.h contains the variable Node* updateStart which is set but never used. This gives an error on newer gcc when Werror is set. Remove this dead variable.

Attachments
proposed fix (2.66 KB, patch) 2011-09-12 03:59 PDT, Andras Becsi	cmarcelo: review-	Details Formatted Diff Diff
proposed patch (2.77 KB, patch) 2011-09-12 06:06 PDT, Andras Becsi	no flags	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Andras Becsi

Comment 1 2011-09-12 03:59:23 PDT

Created attachment 107036 [details] proposed fix

Caio Marcelo de Oliveira Filho

Comment 2 2011-09-12 04:49:20 PDT

LGTM, although I'm not a reviewer. New Red Black tree is based on PODRedBlackTree.h. The 'updateStart' variable was used to call 'updateNode' on the ascendants of the topmost updated node. The new one (RedBlackTree.h) doesn't have this functionality, so it is OK to remove.

Caio Marcelo de Oliveira Filho

Comment 3 2011-09-12 05:00:14 PDT

Comment on attachment 107036 [details] proposed fix View in context: https://bugs.webkit.org/attachment.cgi?id=107036&action=review Ops. Doesn't LGTM yet :P > Source/JavaScriptCore/wtf/RedBlackTree.h:-196 > - Node* newSubTreeRoot = rightRotate(x->parent()->parent()); You need to keep this rightRotate, just ignore the return value. > Source/JavaScriptCore/wtf/RedBlackTree.h:-218 > - Node* newSubTreeRoot = leftRotate(x->parent()->parent()); You need to keep this leftRotate, just ignore the return value.

Andras Becsi

Comment 4 2011-09-12 06:06:50 PDT

Created attachment 107043 [details] proposed patch

Csaba Osztrogonác

Comment 5 2011-09-12 06:24:56 PDT

Comment on attachment 107043 [details] proposed patch LGTM, r=me. ( But cq-, because commit queue still doesn't like my name :( )

Andras Becsi

Comment 6 2011-09-12 06:33:14 PDT

Committed r94954: <http://trac.webkit.org/changeset/94954>

Andras Becsi

Comment 7 2011-09-12 06:34:16 PDT

Comment on attachment 107043 [details] proposed patch Clearing flags from landed patch.

Note You need to log in before you can comment on or make changes to this bug.