Bug 67884

Summary: Delete button icon does not properly update when the device resolution changes dynamically
Product: WebKit Reporter: Beth Dakin <bdakin>
Component: Layout and RenderingAssignee: Beth Dakin <bdakin>
Status: RESOLVED FIXED    
Severity: Normal CC: bdakin
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
darin: review-
Patch darin: review+

Beth Dakin
Reported 2011-09-09 23:31:09 PDT
https://bugs.webkit.org/show_bug.cgi?id=67819 added high resolution platform images to WebCore. The delete button, however, does not dynamically update to the appropriate resolution when the device scale factor changes dynamically.
Attachments
Patch (6.16 KB, patch)
2011-09-15 16:19 PDT, Beth Dakin 		darin: review-
DetailsFormatted DiffDiff
Patch (4.06 KB, patch)
2011-09-15 17:01 PDT, Beth Dakin 		darin: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Beth Dakin
Comment 1 2011-09-09 23:33:21 PDT
<rdar://problem/10104632>
Beth Dakin
Comment 2 2011-09-15 16:19:41 PDT
Created attachment 107562 [details] Patch
Darin Adler
Comment 3 2011-09-15 16:31:36 PDT
Comment on attachment 107562 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=107562&action=review > Source/WebCore/ChangeLog:15 > + takes an optional bool parameter indicated whether or not the change affects the > + Editor since page scale changes don't affect Editor. It seems like the bool parameter indicates whether it’s the device scale factor changing or the page scale factor changing. Calling it “affectsEditor” seems kind of wrong. Instead of adding a bool and attaching the deviceScaleFactorChanged work into the existing function, I suggest putting the code to iterate all the frames and call deviceScaleFactorChanged on each editor directly into Page::setDeviceScaleFactor. You wouldn’t have to touch Frame.h/cpp at all. Iterating all the frames in a page is simple and can be done without recursion.
Beth Dakin
Comment 4 2011-09-15 17:01:04 PDT
Created attachment 107567 [details] Patch
Beth Dakin
Comment 5 2011-09-15 17:17:25 PDT
Thanks! Fixed with revision 95244.
Note You need to log in before you can comment on or make changes to this bug.