Summary: | [Chromium Win] 10% PLT regression r94589 | ||
---|---|---|---|
Product: | WebKit | Reporter: | Adam Barth <abarth> |
Component: | WebCore Misc. | Assignee: | Mike Reed <reed> |
Status: | RESOLVED WONTFIX | ||
Severity: | Normal | CC: | fishd, ggaren, japhet, jar, jshin, kbr, loislo, reed, sam, schenney, slewis |
Priority: | P1 | ||
Version: | 528+ (Nightly build) | ||
Hardware: | All | ||
OS: | All | ||
URL: | http://build.chromium.org/f/chromium/perf/xp-release-dual-core/intl1/report.html?history=150&rev=100517 | ||
Bug Depends on: | |||
Bug Blocks: | 69237 |
Description
Adam Barth
2011-09-09 16:53:28 PDT
I don't know whether this manifests on ports besides Chromium or on other test suites besides intl1. i'll check our tests on Monday. (In reply to comment #2) > i'll check our tests on Monday. I've made some bisecting steps. 94619 - bad 94588 - good (In reply to comment #3) > (In reply to comment #2) > > i'll check our tests on Monday. > > I've made some bisecting steps. > > 94619 - bad > 94588 - good it is 94589 Author: reed@google.com <reed@google.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc> Date: Tue Sep 6 19:21:52 2011 +0000 [skia] never draw with GDI, so that all text can be gpu-accelerated https://bugs.webkit.org/show_bug.cgi?id=65203 Reviewed by Kenneth Russell. Source/WebCore: * platform/graphics/chromium/FontChromiumWin.cpp: (WebCore::TransparencyAwareFontPainter::TransparencyAwareFontPainter::TransparencyAwareFontPainter): (WebCore::TransparencyAwareFontPainter::TransparencyAwareGlyphPainter::TransparencyAwareGlyphPainter): (WebCore::TransparencyAwareFontPainter::TransparencyAwareGlyphPainter::drawGlyphs): (WebCore::TransparencyAwareFontPainter::TransparencyAwareUniscribePainter::TransparencyAwareUniscribePainter): (WebCore::drawGlyphsWin): (WebCore::Font::drawComplexText): * platform/graphics/chromium/UniscribeHelper.cpp: (WebCore::UniscribeHelper::draw): * platform/graphics/skia/PlatformContextSkia.cpp: * platform/graphics/skia/PlatformContextSkia.h: * platform/graphics/skia/SkiaFontWin.cpp: (WebCore::skiaDrawText): * platform/graphics/skia/SkiaFontWin.h: LayoutTests: * platform/chromium/test_expectations.txt: Would it make sense to roll out that patch while we investigate? We don't want this perf regression to hide other problems. (Just so others don't spend too long looking, this patch is after the M15 branch point.) What's the current status of this issue? What the patch rolled out? Was the performance regression fixed? |