Bug 67865

Summary: [V8] V8WebKitPoint::constructorCallback leaks
Product: WebKit Reporter: Julien Chaffraix <jchaffraix>
Component: WebCore JavaScriptAssignee: Julien Chaffraix <jchaffraix>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, dglazkov, japhet, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Proposed change: use toV8 and correct RefPtr usage. none

Julien Chaffraix
Reported 2011-09-09 14:24:06 PDT
Seen under valgrind while testing LayoutTests/fast/js/instanceof-XMLHTTPRequest.html. Also using a PassRefPtr in this code is not right.
Attachments
Proposed change: use toV8 and correct RefPtr usage. (1.74 KB, patch)
2011-09-09 14:32 PDT, Julien Chaffraix 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Julien Chaffraix
Comment 1 2011-09-09 14:32:18 PDT
Created attachment 106924 [details] Proposed change: use toV8 and correct RefPtr usage.
Adam Barth
Comment 2 2011-09-09 17:07:35 PDT
Comment on attachment 106924 [details] Proposed change: use toV8 and correct RefPtr usage. Wow.
Adam Barth
Comment 3 2011-09-09 17:08:07 PDT
Looks like the leak was added by japhet and reviewed by dglazkov two years ago in http://trac.webkit.org/changeset/48834
Julien Chaffraix
Comment 4 2011-09-09 17:15:08 PDT
Comment on attachment 106924 [details] Proposed change: use toV8 and correct RefPtr usage. Thanks Adam!
WebKit Review Bot
Comment 5 2011-09-09 18:15:19 PDT
Comment on attachment 106924 [details] Proposed change: use toV8 and correct RefPtr usage. Clearing flags on attachment: 106924 Committed r94894: <http://trac.webkit.org/changeset/94894>
WebKit Review Bot
Comment 6 2011-09-09 18:15:23 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.