Bug 67860

Summary: Never #define ENABLE_SINGLE_THREADED, !ENABLE_JSC_MULTIPLE_THREADS, or !ENABLE_WTF_MULTIPLE_THREADS
Product: WebKit Reporter: Geoffrey Garen <ggaren>
Component: New BugsAssignee: Geoffrey Garen <ggaren>
Status: RESOLVED FIXED    
Severity: Normal CC: mitz, ossy, paroga, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
patch
none
more straightforward way of doing things, suggested by mitz mitz: review+

Geoffrey Garen
Reported 2011-09-09 12:05:49 PDT
First step toward making the baseline platform assumption that threads exist.
Attachments
patch (2.38 KB, patch)
2011-09-09 12:06 PDT, Geoffrey Garen 		no flags
DetailsFormatted DiffDiff
more straightforward way of doing things, suggested by mitz (1.58 KB, patch)
2011-09-09 12:37 PDT, Geoffrey Garen 		mitz: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Geoffrey Garen
Comment 1 2011-09-09 12:06:29 PDT
Created attachment 106898 [details] patch As discussed on webkit-dev.
WebKit Review Bot
Comment 2 2011-09-09 12:09:46 PDT
Attachment 106898 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source..." exit_code: 1 Source/JavaScriptCore/ChangeLog:1: ChangeLog entry has no bug number [changelog/bugnumber] [5] Total errors found: 1 in 1 files If any of these errors are false positives, please file a bug against check-webkit-style.
Geoffrey Garen
Comment 3 2011-09-09 12:37:02 PDT
Created attachment 106902 [details] more straightforward way of doing things, suggested by mitz
Geoffrey Garen
Comment 4 2011-09-09 12:44:12 PDT
Committed r94871: <http://trac.webkit.org/changeset/94871>
Csaba Osztrogonác
Comment 5 2011-09-09 14:44:13 PDT
It broke Qt build on Windows: ./release/libjscore.a(MachineStackMarker.o):MachineStackMarker.cpp:(.text+0x43): undefined reference to `__imp__pthread_self' ./release/libjscore.a(MachineStackMarker.o):MachineStackMarker.cpp:(.text+0x88): undefined reference to `__imp__pthread_equal' ./release/libjscore.a(MachineStackMarker.o):MachineStackMarker.cpp:(.text+0xab): undefined reference to `__imp__pthread_equal' ./release/libjscore.a(MachineStackMarker.o):MachineStackMarker.cpp:(.text+0x1f5): undefined reference to `__imp__pthread_key_delete' ./release/libjscore.a(MachineStackMarker.o):MachineStackMarker.cpp:(.text+0x2d0): undefined reference to `__imp__pthread_key_create' ./release/libjscore.a(MachineStackMarker.o):MachineStackMarker.cpp:(.text+0x338): undefined reference to `__imp__pthread_getspecific' ./release/libjscore.a(MachineStackMarker.o):MachineStackMarker.cpp:(.text+0x366): undefined reference to `__imp__pthread_setspecific' ./release/libjscore.a(MachineStackMarker.o):MachineStackMarker.cpp:(.text+0x36b): undefined reference to `__imp__pthread_self' ./release/libjscore.a(MachineStackMarker.o):MachineStackMarker.cpp:(.text+0x386): undefined reference to `__imp__pthread_getw32threadhandle_np' ./release/libjscore.a(MachineStackMarker.o):MachineStackMarker.cpp:(.text+0x588): undefined reference to `__imp__pthread_self' ./release/libjscore.a(MachineStackMarker.o):MachineStackMarker.cpp:(.text+0x5cd): undefined reference to `__imp__pthread_equal' ./release/libjscore.a(MachineStackMarker.o):MachineStackMarker.cpp:(.text+0x5f0): undefined reference to `__imp__pthread_equal' ./release/libjscore.a(MachineStackMarker.o):MachineStackMarker.cpp:(.text+0x9ba): undefined reference to `__imp__pthread_self' ./release/libjscore.a(MachineStackMarker.o):MachineStackMarker.cpp:(.text+0xa00): undefined reference to `__imp__pthread_equal'
Patrick R. Gansterer
Comment 6 2011-09-12 04:08:42 PDT
Committed r94952: <http://trac.webkit.org/changeset/94952>
Note You need to log in before you can comment on or make changes to this bug.