Bug 67860 - Never #define ENABLE_SINGLE_THREADED, !ENABLE_JSC_MULTIPLE_THREADS, or !ENABLE_WTF_MULTIPLE_THREADS
Summary: Never #define ENABLE_SINGLE_THREADED, !ENABLE_JSC_MULTIPLE_THREADS, or !ENABL...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Geoffrey Garen
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-09-09 12:05 PDT by Geoffrey Garen
Modified: 2011-09-12 04:08 PDT (History)
4 users (show)

See Also:


Attachments
patch (2.38 KB, patch)
2011-09-09 12:06 PDT, Geoffrey Garen
no flags Details | Formatted Diff | Diff
more straightforward way of doing things, suggested by mitz (1.58 KB, patch)
2011-09-09 12:37 PDT, Geoffrey Garen
mitz: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Geoffrey Garen 2011-09-09 12:05:49 PDT
First step toward making the baseline platform assumption that threads exist.
Comment 1 Geoffrey Garen 2011-09-09 12:06:29 PDT
Created attachment 106898 [details]
patch

As discussed on webkit-dev.
Comment 2 WebKit Review Bot 2011-09-09 12:09:46 PDT
Attachment 106898 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source..." exit_code: 1

Source/JavaScriptCore/ChangeLog:1:  ChangeLog entry has no bug number  [changelog/bugnumber] [5]
Total errors found: 1 in 1 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Geoffrey Garen 2011-09-09 12:37:02 PDT
Created attachment 106902 [details]
more straightforward way of doing things, suggested by mitz
Comment 4 Geoffrey Garen 2011-09-09 12:44:12 PDT
Committed r94871: <http://trac.webkit.org/changeset/94871>
Comment 5 Csaba Osztrogonác 2011-09-09 14:44:13 PDT
It broke Qt build on Windows:

./release/libjscore.a(MachineStackMarker.o):MachineStackMarker.cpp:(.text+0x43): undefined reference to `__imp__pthread_self'
./release/libjscore.a(MachineStackMarker.o):MachineStackMarker.cpp:(.text+0x88): undefined reference to `__imp__pthread_equal'
./release/libjscore.a(MachineStackMarker.o):MachineStackMarker.cpp:(.text+0xab): undefined reference to `__imp__pthread_equal'
./release/libjscore.a(MachineStackMarker.o):MachineStackMarker.cpp:(.text+0x1f5): undefined reference to `__imp__pthread_key_delete'
./release/libjscore.a(MachineStackMarker.o):MachineStackMarker.cpp:(.text+0x2d0): undefined reference to `__imp__pthread_key_create'
./release/libjscore.a(MachineStackMarker.o):MachineStackMarker.cpp:(.text+0x338): undefined reference to `__imp__pthread_getspecific'
./release/libjscore.a(MachineStackMarker.o):MachineStackMarker.cpp:(.text+0x366): undefined reference to `__imp__pthread_setspecific'
./release/libjscore.a(MachineStackMarker.o):MachineStackMarker.cpp:(.text+0x36b): undefined reference to `__imp__pthread_self'
./release/libjscore.a(MachineStackMarker.o):MachineStackMarker.cpp:(.text+0x386): undefined reference to `__imp__pthread_getw32threadhandle_np'
./release/libjscore.a(MachineStackMarker.o):MachineStackMarker.cpp:(.text+0x588): undefined reference to `__imp__pthread_self'
./release/libjscore.a(MachineStackMarker.o):MachineStackMarker.cpp:(.text+0x5cd): undefined reference to `__imp__pthread_equal'
./release/libjscore.a(MachineStackMarker.o):MachineStackMarker.cpp:(.text+0x5f0): undefined reference to `__imp__pthread_equal'
./release/libjscore.a(MachineStackMarker.o):MachineStackMarker.cpp:(.text+0x9ba): undefined reference to `__imp__pthread_self'
./release/libjscore.a(MachineStackMarker.o):MachineStackMarker.cpp:(.text+0xa00): undefined reference to `__imp__pthread_equal'
Comment 6 Patrick R. Gansterer 2011-09-12 04:08:42 PDT
Committed r94952: <http://trac.webkit.org/changeset/94952>