|Summary:||Buildbot may use RunWebKitTest's evaluateCommand on bots that run nrwt|
|Product:||WebKit||Reporter:||Ryosuke Niwa <rniwa>|
|Component:||Tools / Tests||Assignee:||Nobody <webkit-unassigned>|
|Severity:||Normal||CC:||aroben, dpranke, eric, tony|
|Version:||528+ (Nightly build)|
|Bug Depends on:|
Description Ryosuke Niwa 2011-09-09 10:15:55 PDT
Some ports use RunWebKitTests instead of NewRunWebKitTests to run tests, and using RunWebKitTests.evaluateCommand after calling _parseNewRunWebKitTestsOutput.
Comment 2 Ryosuke Niwa 2011-09-09 10:38:16 PDT
We really need this patch landed ASAP. Right now, this bug is making Mac bots red.
Comment 3 Dirk Pranke 2011-09-09 10:54:34 PDT
Comment on attachment 106885 [details] fixes the bug Shouldn't we switch the ports that are using RunWebKitTests to NewRunWebKitTests instead of modifying both evaluateCommands ?
Comment 4 Ryosuke Niwa 2011-09-09 11:07:38 PDT
(In reply to comment #3) > (From update of attachment 106885 [details]) > Shouldn't we switch the ports that are using RunWebKitTests to NewRunWebKitTests instead of modifying both evaluateCommands ? We can't because some of bots are still in the process of transitioning and we may need to move it back.
Comment 5 Dirk Pranke 2011-09-09 11:16:23 PDT
Comment on attachment 106885 [details] fixes the bug Per conversation over IRC, some (most?) bots are invoking NRWT through the run-webkit-tests wrapper, and so they we need to update the parser in the wrapper command. R+. We really need to consolidate these things and finish the cutover though ...
Comment 6 Ryosuke Niwa 2011-09-09 11:20:50 PDT
Comment on attachment 106885 [details] fixes the bug Clearing flags on attachment: 106885 Committed r94868: <http://trac.webkit.org/changeset/94868>
Comment 7 Ryosuke Niwa 2011-09-09 11:20:54 PDT
All reviewed patches have been landed. Closing bug.