| Summary: | Buildbot may use RunWebKitTest's evaluateCommand on bots that run nrwt | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Ryosuke Niwa <rniwa> | ||||
| Component: | Tools / Tests | Assignee: | Nobody <webkit-unassigned> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | aroben, dpranke, eric, tony | ||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Bug Depends on: | |||||||
| Bug Blocks: | 64812 | ||||||
| Attachments: |
|
||||||
|
Description
Ryosuke Niwa
2011-09-09 10:15:55 PDT
Created attachment 106885 [details]
fixes the bug
We really need this patch landed ASAP. Right now, this bug is making Mac bots red. Comment on attachment 106885 [details]
fixes the bug
Shouldn't we switch the ports that are using RunWebKitTests to NewRunWebKitTests instead of modifying both evaluateCommands ?
(In reply to comment #3) > (From update of attachment 106885 [details]) > Shouldn't we switch the ports that are using RunWebKitTests to NewRunWebKitTests instead of modifying both evaluateCommands ? We can't because some of bots are still in the process of transitioning and we may need to move it back. Comment on attachment 106885 [details]
fixes the bug
Per conversation over IRC, some (most?) bots are invoking NRWT through the run-webkit-tests wrapper, and so they we need to update the parser in the wrapper command. R+. We really need to consolidate these things and finish the cutover though ...
Comment on attachment 106885 [details] fixes the bug Clearing flags on attachment: 106885 Committed r94868: <http://trac.webkit.org/changeset/94868> All reviewed patches have been landed. Closing bug. |