Bug 67844

Summary:

[skia] remove dead code, no functionality change

Product:

WebKit

Reporter:

Mike Reed <reed>

Component:

New Bugs

Assignee:

Mike Reed <reed>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

abarth, dglazkov, jamesr, kbr, senorblanco, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	none
Patch	none

Mike Reed

Reported 2011-09-09 06:28:52 PDT

[skia] remove dead code, no functionality change

Attachments
Patch (9.77 KB, patch) 2011-09-09 06:30 PDT, Mike Reed	no flags	Details Formatted Diff Diff
Patch (9.80 KB, patch) 2011-09-09 11:11 PDT, Mike Reed	no flags	Details Formatted Diff Diff
Patch (9.86 KB, patch) 2011-09-12 08:50 PDT, Mike Reed	no flags	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Mike Reed

Comment 1 2011-09-09 06:30:57 PDT

Created attachment 106865 [details] Patch

WebKit Review Bot

Comment 2 2011-09-09 08:54:03 PDT

Comment on attachment 106865 [details] Patch Attachment 106865 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/9622849 New failing tests: svg/W3C-SVG-1.1/animate-elem-04-t.svg platform/chromium/fast/text/text-stroke-with-border.html scrollbars/scrollbar-orientation.html scrollbars/disabled-scrollbar.html scrollbars/scrollbar-buttons.html platform/mac-snowleopard/platform/mac/fast/text/international/Geeza-Pro-vertical-metrics-adjustment.html scrollbars/listbox-scrollbar-combinations.html scrollbars/scrollbar-click-does-not-blur-content.html svg/W3C-SVG-1.1/animate-elem-02-t.svg svg/W3C-SVG-1.1/animate-elem-05-t.svg scrollbars/scrollbars-on-positioned-content.html scrollbars/overflow-scrollbar-combinations.html scrollbars/basic-scrollbar.html scrollbars/scrollbar-middleclick-nopaste.html svg/W3C-SVG-1.1/animate-elem-03-t.svg

James Robinson

Comment 3 2011-09-09 11:02:57 PDT

Comment on attachment 106865 [details] Patch The EWS bot doesn't seem to think this is dead code. Can you check if those failures are due to this patch?

Mike Reed

Comment 4 2011-09-09 11:11:22 PDT

Created attachment 106889 [details] Patch

Mike Reed

Comment 5 2011-09-09 11:15:35 PDT

My read of the failure of cr-linux was that it didn't pass w/o my patch, plus my change is strictly in a windows-only file, so I'm having trouble seeing how it affected the linux bot. Am I misreading this?

Adam Barth

Comment 6 2011-09-09 11:38:58 PDT

> Am I misreading this? It is hard to see how changing this file could effect Linux. It's certainly possible the bot is confused.

Mike Reed

Comment 7 2011-09-09 12:01:38 PDT

rebaselined (just in case) and resubmitted (with no changes) to trigger another stab at cr-linux...

Kenneth Russell

Comment 8 2011-09-10 14:26:47 PDT

Comment on attachment 106889 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=106889&action=review Looks good but ChangeLog needs a minor update. r=me > Source/WebCore/ChangeLog:8 > + No new tests. (OOPS!) That OOPS will trigger a problem during commit.

WebKit Review Bot

Comment 9 2011-09-12 08:10:03 PDT

Comment on attachment 106889 [details] Patch Rejecting attachment 106889 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: abf2546dd1a2ed81c56c4c6ee34cd6b74bcb84c5 r94956 = f5aad96879400e3b3556e085f2c15249f6183cee Done rebuilding .git/svn/refs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc First, rewinding head to replay your work on top of it... Fast-forwarded master to refs/remotes/origin/master. Updating chromium port dependencies using gclient... ________ running '/usr/bin/python gyp_webkit' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium' Updating webkit projects from gyp files... Full output: http://queues.webkit.org/results/9647004

Mike Reed

Comment 10 2011-09-12 08:50:06 PDT

Created attachment 107053 [details] Patch

Mike Reed

Comment 11 2011-09-12 08:50:25 PDT

just updated ChangeLog

Mike Reed

Comment 12 2011-09-12 08:51:04 PDT

Comment on attachment 107053 [details] Patch resending to commit bot, as only the ChangeLog seemed to be at issue.

WebKit Review Bot

Comment 13 2011-09-12 09:02:49 PDT

Comment on attachment 107053 [details] Patch Rejecting attachment 107053 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 1 Last 500 characters of output: hangeLog does not appear to be a valid reviewer according to committers.py. ERROR: /mnt/git/webkit-commit-queue/Source/WebCore/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive). Updating OpenSource Current branch master is up to date. Updating chromium port dependencies using gclient... ________ running '/usr/bin/python gyp_webkit' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium' Updating webkit projects from gyp files... Full output: http://queues.webkit.org/results/9646023

Mike Reed

Comment 14 2011-09-12 09:22:20 PDT

Comment on attachment 107053 [details] Patch looking for + or rubberstamp to resubmit after fixing ChangeLog

Kenneth Russell

Comment 15 2011-09-12 09:27:21 PDT

Comment on attachment 107053 [details] Patch Looks fine.

WebKit Review Bot

Comment 16 2011-09-12 10:30:12 PDT

Comment on attachment 107053 [details] Patch Clearing flags on attachment: 107053 Committed r94961: <http://trac.webkit.org/changeset/94961>

WebKit Review Bot

Comment 17 2011-09-12 10:30:18 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.